From: Peng Wang <rocking@xxxxxxxxxx>
Subject: mm/slub.c: freelist is ensured to be NULL when new_slab() fails
new_slab_objects() will return immediately if freelist is not NULL.
if (freelist)
return freelist;
One more assignment operation could be avoided.
Link: http://lkml.kernel.org/r/20181229062512.30469-1-rocking@xxxxxxxxxx
Signed-off-by: Peng Wang <rocking@xxxxxxxxxx>
Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Christoph Lameter <cl@xxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slub.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/mm/slub.c~mm-slubc-freelist-is-ensured-to-be-null-when-new_slab-fails
+++ a/mm/slub.c
@@ -2482,8 +2482,7 @@ static inline void *new_slab_objects(str
stat(s, ALLOC_SLAB);
c->page = page;
*pc = c;
- } else
- freelist = NULL;
+ }
return freelist;
}
_
