The patch titled
Subject: mm/huge_memory.c: fix "orig_pud" set but not used
has been added to the -mm tree. Its filename is
mm-hugepages-fix-orig_pud-set-but-not-used.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-hugepages-fix-orig_pud-set-but-not-used.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-hugepages-fix-orig_pud-set-but-not-used.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Qian Cai <cai@xxxxxx>
Subject: mm/huge_memory.c: fix "orig_pud" set but not used
a00cc7d9dd93 ("mm, x86: add support for PUD-sized transparent hugepages")
introduced pudp_huge_get_and_clear_full() but no one uses its return code.
In order to not diverge from pmdp_huge_get_and_clear_full(), just change
zap_huge_pud() to not assign the return value from
pudp_huge_get_and_clear_full().
mm/huge_memory.c: In function 'zap_huge_pud':
mm/huge_memory.c:1982:8: warning: variable 'orig_pud' set but not used
[-Wunused-but-set-variable]
pud_t orig_pud;
^~~~~~~~
Link: http://lkml.kernel.org/r/20190301221956.97493-1-cai@xxxxxx
Signed-off-by: Qian Cai <cai@xxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/huge_memory.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/mm/huge_memory.c~mm-hugepages-fix-orig_pud-set-but-not-used
+++ a/mm/huge_memory.c
@@ -1982,7 +1982,6 @@ spinlock_t *__pud_trans_huge_lock(pud_t
int zap_huge_pud(struct mmu_gather *tlb, struct vm_area_struct *vma,
pud_t *pud, unsigned long addr)
{
- pud_t orig_pud;
spinlock_t *ptl;
ptl = __pud_trans_huge_lock(pud, vma);
@@ -1994,8 +1993,7 @@ int zap_huge_pud(struct mmu_gather *tlb,
* pgtable_trans_huge_withdraw after finishing pudp related
* operations.
*/
- orig_pud = pudp_huge_get_and_clear_full(tlb->mm, addr, pud,
- tlb->fullmm);
+ pudp_huge_get_and_clear_full(tlb->mm, addr, pud, tlb->fullmm);
tlb_remove_pud_tlb_entry(tlb, pud, addr);
if (vma_is_dax(vma)) {
spin_unlock(ptl);
_
Patches currently in -mm which might be from cai@xxxxxx are
page_poison-play-nicely-with-kasan.patch
slab-kmemleak-no-scan-alien-caches.patch
slub-remove-an-unused-addr-argument.patch
mm-compaction-be-selective-about-what-pageblocks-to-clear-skip-hints-fix.patch
mm-page_ext-fix-an-imbalance-with-kmemleak.patch
memcg-fix-a-bad-line.patch
mm-hotplug-fix-an-imbalance-with-debug_pagealloc.patch
mm-hotplug-fix-an-imbalance-with-debug_pagealloc.patch
mm-hugepages-fix-orig_pud-set-but-not-used.patch
mm-sparse-fix-a-bad-comparison.patch
signal-allow-the-null-signal-in-rt_sigqueueinfo.patch
