The patch titled
Subject: mm/workingset: remove unused @mapping argument in workingset_eviction()
has been added to the -mm tree. Its filename is
mm-workingset-remove-unused-mapping-argument-in-workingset_eviction.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-workingset-remove-unused-mapping-argument-in-workingset_eviction.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-workingset-remove-unused-mapping-argument-in-workingset_eviction.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
Subject: mm/workingset: remove unused @mapping argument in workingset_eviction()
workingset_eviction() doesn't use and never did use the @mapping argument.
Remove it.
Link: http://lkml.kernel.org/r/20190228083329.31892-1-aryabinin@xxxxxxxxxxxxx
Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
Acked-by: Johannes Weiner <hannes@xxxxxxxxxxx>
Acked-by: Rik van Riel <riel@xxxxxxxxxxx>
Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxxxx>
Cc: William Kucharski <william.kucharski@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/swap.h | 2 +-
mm/vmscan.c | 2 +-
mm/workingset.c | 5 ++---
3 files changed, 4 insertions(+), 5 deletions(-)
--- a/include/linux/swap.h~mm-workingset-remove-unused-mapping-argument-in-workingset_eviction
+++ a/include/linux/swap.h
@@ -307,7 +307,7 @@ struct vma_swap_readahead {
};
/* linux/mm/workingset.c */
-void *workingset_eviction(struct address_space *mapping, struct page *page);
+void *workingset_eviction(struct page *page);
void workingset_refault(struct page *page, void *shadow);
void workingset_activation(struct page *page);
--- a/mm/vmscan.c~mm-workingset-remove-unused-mapping-argument-in-workingset_eviction
+++ a/mm/vmscan.c
@@ -952,7 +952,7 @@ static int __remove_mapping(struct addre
*/
if (reclaimed && page_is_file_cache(page) &&
!mapping_exiting(mapping) && !dax_mapping(mapping))
- shadow = workingset_eviction(mapping, page);
+ shadow = workingset_eviction(page);
__delete_from_page_cache(page, shadow);
xa_unlock_irqrestore(&mapping->i_pages, flags);
--- a/mm/workingset.c~mm-workingset-remove-unused-mapping-argument-in-workingset_eviction
+++ a/mm/workingset.c
@@ -215,13 +215,12 @@ static void unpack_shadow(void *shadow,
/**
* workingset_eviction - note the eviction of a page from memory
- * @mapping: address space the page was backing
* @page: the page being evicted
*
- * Returns a shadow entry to be stored in @mapping->i_pages in place
+ * Returns a shadow entry to be stored in @page->mapping->i_pages in place
* of the evicted @page so that a later refault can be detected.
*/
-void *workingset_eviction(struct address_space *mapping, struct page *page)
+void *workingset_eviction(struct page *page)
{
struct pglist_data *pgdat = page_pgdat(page);
struct mem_cgroup *memcg = page_memcg(page);
_
Patches currently in -mm which might be from aryabinin@xxxxxxxxxxxxx are
kasan-remove-use-after-scope-bugs-detection.patch
mm-workingset-remove-unused-mapping-argument-in-workingset_eviction.patch
mm-remove-zone_lru_lock-function-access-lru_lock-directly.patch
mm-compaction-pass-pgdat-to-too_many_isolated-instead-of-zone.patch
mm-vmscan-remove-unused-lru_pages-argument.patch
