The patch titled
Subject: <linux/kernel.h>: drop the gcc-3.3 'const' hack in roundup()
has been added to the -mm tree. Its filename is
linux-kernelh-drop-the-gcc-33-const-hack-in-roundup.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/linux-kernelh-drop-the-gcc-33-const-hack-in-roundup.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/linux-kernelh-drop-the-gcc-33-const-hack-in-roundup.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Subject: <linux/kernel.h>: drop the gcc-3.3 'const' hack in roundup()
The single quotation marks around "const" were causing a documentation
markup warning with reST. Instead of fixing that warning, just delete
that comment line and the gcc-3.3 hack of using "const" in the roundup()
macro since gcc-3.3 is no longer supported for kernel builds.
I did around 20 different $arch builds with no problems, but we'll just
have to see if this causes problems for anyone else out there.
Link: http://lkml.kernel.org/r/ec5dcf72-7c3e-3513-af0c-4003ed598854@xxxxxxxxxxxxx
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Suggested-by: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
--- a/include/linux/kernel.h~linux-kernelh-drop-the-gcc-33-const-hack-in-roundup
+++ a/include/linux/kernel.h
@@ -134,12 +134,10 @@
*
* Rounds @x up to next multiple of @y. If @y will always be a power
* of 2, consider using the faster round_up().
- *
- * The `const' here prevents gcc-3.3 from calling __divdi3
*/
#define roundup(x, y) ( \
{ \
- const typeof(y) __y = y; \
+ typeof(y) __y = y; \
(((x) + (__y - 1)) / __y) * __y; \
} \
)
_
Patches currently in -mm which might be from rdunlap@xxxxxxxxxxxxx are
linux-kernelh-drop-the-gcc-33-const-hack-in-roundup.patch
pinctrl-fix-pxa2xxc-build-warnings.patch
fs-fs_parser-fix-printk-format-warning.patch
