+ assoc_array-mark-expected-switch-fall-through.patch added to -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled
     Subject: lib/assoc_array.c: mark expected switch fall-through
has been added to the -mm tree.  Its filename is
     assoc_array-mark-expected-switch-fall-through.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/assoc_array-mark-expected-switch-fall-through.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/assoc_array-mark-expected-switch-fall-through.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
Subject: lib/assoc_array.c: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.

This patch fixes the following warning:

lib/assoc_array.c: In function `assoc_array_delete':
lib/assoc_array.c:1110:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   for (slot = 0; slot < ASSOC_ARRAY_FAN_OUT; slot++) {
   ^~~
lib/assoc_array.c:1118:2: note: here
  case assoc_array_walk_tree_empty:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Link: http://lkml.kernel.org/r/20190212212206.GA16378@embeddedor
Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---

 lib/assoc_array.c |    1 +
 1 file changed, 1 insertion(+)

--- a/lib/assoc_array.c~assoc_array-mark-expected-switch-fall-through
+++ a/lib/assoc_array.c
@@ -1115,6 +1115,7 @@ struct assoc_array_edit *assoc_array_del
 						index_key))
 				goto found_leaf;
 		}
+		/* fall through */
 	case assoc_array_walk_tree_empty:
 	case assoc_array_walk_found_wrong_shortcut:
 	default:
_

Patches currently in -mm which might be from gustavo@xxxxxxxxxxxxxx are

ocfs2-use-zero-sized-array-and-struct_size-in-kzalloc.patch
mm-memcontrol-use-struct_size-in-kmalloc.patch
assoc_array-mark-expected-switch-fall-through.patch
gcov-use-struct_size-in-kzalloc.patch
ipc-semc-replace-kvmalloc-memset-with-kvzalloc-and-use-struct_size.patch




[Index of Archives]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux