The patch titled
Subject: mm/vmalloc.c: convert vmap_lazy_nr to atomic_long_t
has been added to the -mm tree. Its filename is
mm-vmalloc-convert-vmap_lazy_nr-to-atomic_long_t.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-vmalloc-convert-vmap_lazy_nr-to-atomic_long_t.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-convert-vmap_lazy_nr-to-atomic_long_t.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: "Uladzislau Rezki (Sony)" <urezki@xxxxxxxxx>
Subject: mm/vmalloc.c: convert vmap_lazy_nr to atomic_long_t
vmap_lazy_nr variable has atomic_t type that is 4 bytes integer value on
both 32 and 64 bit systems. lazy_max_pages() deals with "unsigned long"
that is 8 bytes on 64 bit system, thus vmap_lazy_nr should be 8 bytes on
64 bit as well.
Link: http://lkml.kernel.org/r/20190131162452.25879-1-urezki@xxxxxxxxx
Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Michal Hocko <mhocko@xxxxxxxx>
Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
Cc: Thomas Garnier <thgarnie@xxxxxxxxxx>
Cc: Oleksiy Avramchenko <oleksiy.avramchenko@xxxxxxxxxxxxxx>
Cc: Joel Fernandes <joelaf@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
--- a/mm/vmalloc.c~mm-vmalloc-convert-vmap_lazy_nr-to-atomic_long_t
+++ a/mm/vmalloc.c
@@ -632,7 +632,7 @@ static unsigned long lazy_max_pages(void
return log * (32UL * 1024 * 1024 / PAGE_SIZE);
}
-static atomic_t vmap_lazy_nr = ATOMIC_INIT(0);
+static atomic_long_t vmap_lazy_nr = ATOMIC_LONG_INIT(0);
/*
* Serialize vmap purging. There is no actual criticial section protected
@@ -650,7 +650,7 @@ static void purge_fragmented_blocks_allc
*/
void set_iounmap_nonlazy(void)
{
- atomic_set(&vmap_lazy_nr, lazy_max_pages()+1);
+ atomic_long_set(&vmap_lazy_nr, lazy_max_pages()+1);
}
/*
@@ -658,10 +658,10 @@ void set_iounmap_nonlazy(void)
*/
static bool __purge_vmap_area_lazy(unsigned long start, unsigned long end)
{
+ unsigned long resched_threshold;
struct llist_node *valist;
struct vmap_area *va;
struct vmap_area *n_va;
- int resched_threshold;
lockdep_assert_held(&vmap_purge_lock);
@@ -681,16 +681,16 @@ static bool __purge_vmap_area_lazy(unsig
}
flush_tlb_kernel_range(start, end);
- resched_threshold = (int) lazy_max_pages() << 1;
+ resched_threshold = lazy_max_pages() << 1;
spin_lock(&vmap_area_lock);
llist_for_each_entry_safe(va, n_va, valist, purge_list) {
- int nr = (va->va_end - va->va_start) >> PAGE_SHIFT;
+ unsigned long nr = (va->va_end - va->va_start) >> PAGE_SHIFT;
__free_vmap_area(va);
- atomic_sub(nr, &vmap_lazy_nr);
+ atomic_long_sub(nr, &vmap_lazy_nr);
- if (atomic_read(&vmap_lazy_nr) < resched_threshold)
+ if (atomic_long_read(&vmap_lazy_nr) < resched_threshold)
cond_resched_lock(&vmap_area_lock);
}
spin_unlock(&vmap_area_lock);
@@ -727,10 +727,10 @@ static void purge_vmap_area_lazy(void)
*/
static void free_vmap_area_noflush(struct vmap_area *va)
{
- int nr_lazy;
+ unsigned long nr_lazy;
- nr_lazy = atomic_add_return((va->va_end - va->va_start) >> PAGE_SHIFT,
- &vmap_lazy_nr);
+ nr_lazy = atomic_long_add_return((va->va_end - va->va_start) >>
+ PAGE_SHIFT, &vmap_lazy_nr);
/* After this point, we may free va at any time */
llist_add(&va->purge_list, &vmap_purge_list);
_
Patches currently in -mm which might be from urezki@xxxxxxxxx are
vmalloc-export-__vmalloc_node_range-for-config_test_vmalloc_module.patch
vmalloc-add-test-driver-to-analyse-vmalloc-allocator.patch
vmalloc-add-test-driver-to-analyse-vmalloc-allocator-fix.patch
selftests-vm-add-script-helper-for-config_test_vmalloc_module.patch
mm-vmalloc-fix-kernel-bug-at-mm-vmallocc-512.patch
mm-add-priority-threshold-to-__purge_vmap_area_lazy.patch
mm-vmalloc-convert-vmap_lazy_nr-to-atomic_long_t.patch
