The patch titled
Subject: lib/cmdline.c: annotate implicit fall throughs
has been added to the -mm tree. Its filename is
lib-cmdlinec-annotate-implicit-fall-throughs.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-cmdlinec-annotate-implicit-fall-throughs.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-cmdlinec-annotate-implicit-fall-throughs.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mathieu Malaterre <malat@xxxxxxxxxx>
Subject: lib/cmdline.c: annotate implicit fall throughs
There is a plan to build the kernel with -Wimplicit-fallthrough and these
places in the code produced warnings (W=1). Fix them up.
This commit remove the following warnings:
lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
Link: http://lkml.kernel.org/r/20190114202143.14130-1-malat@xxxxxxxxxx
Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
Acked-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/cmdline.c | 5 +++++
1 file changed, 5 insertions(+)
--- a/lib/cmdline.c~lib-cmdlinec-annotate-implicit-fall-throughs
+++ a/lib/cmdline.c
@@ -135,18 +135,23 @@ unsigned long long memparse(const char *
case 'E':
case 'e':
ret <<= 10;
+ /* fall through */
case 'P':
case 'p':
ret <<= 10;
+ /* fall through */
case 'T':
case 't':
ret <<= 10;
+ /* fall through */
case 'G':
case 'g':
ret <<= 10;
+ /* fall through */
case 'M':
case 'm':
ret <<= 10;
+ /* fall through */
case 'K':
case 'k':
ret <<= 10;
_
Patches currently in -mm which might be from malat@xxxxxxxxxx are
lib-cmdlinec-annotate-implicit-fall-throughs.patch
kernel-sys-annotate-implicit-fall-through.patch
ipc-annotate-implicit-fall-through.patch
