The patch titled
Subject: mm, memory_hotplug: __offline_pages fix wrong locking
has been added to the -mm tree. Its filename is
mm-memory_hotplug-__offline_pages-fix-wrong-locking.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-memory_hotplug-__offline_pages-fix-wrong-locking.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-memory_hotplug-__offline_pages-fix-wrong-locking.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Michal Hocko <mhocko@xxxxxxxx>
Subject: mm, memory_hotplug: __offline_pages fix wrong locking
Jan has noticed that we do double unlock on some failure paths when
offlining a page range. This is indeed the case when test_pages_in_a_zone
respp. start_isolate_page_range fail. This was an omission when forward
porting the debugging patch from an older kernel.
Fix the issue by dropping mem_hotplug_done from the failure condition and
keeping the single unlock in the catch all failure path.
Link: http://lkml.kernel.org/r/20190115120307.22768-1-mhocko@xxxxxxxxxx
Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining failure")
Signed-off-by: Michal Hocko <mhocko@xxxxxxxx>
Reported-by: Jan Kara <jack@xxxxxxx>
Reviewed-by: Jan Kara <jack@xxxxxxx>
Tested-by: Jan Kara <jack@xxxxxxx>
Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/memory_hotplug.c | 2 --
1 file changed, 2 deletions(-)
--- a/mm/memory_hotplug.c~mm-memory_hotplug-__offline_pages-fix-wrong-locking
+++ a/mm/memory_hotplug.c
@@ -1570,7 +1570,6 @@ static int __ref __offline_pages(unsigne
we assume this for now. .*/
if (!test_pages_in_a_zone(start_pfn, end_pfn, &valid_start,
&valid_end)) {
- mem_hotplug_done();
ret = -EINVAL;
reason = "multizone range";
goto failed_removal;
@@ -1585,7 +1584,6 @@ static int __ref __offline_pages(unsigne
MIGRATE_MOVABLE,
SKIP_HWPOISON | REPORT_FAILURE);
if (ret) {
- mem_hotplug_done();
reason = "failure to isolate range";
goto failed_removal;
}
_
Patches currently in -mm which might be from mhocko@xxxxxxxx are
mm-memory_hotplug-is_mem_section_removable-do-not-pass-the-end-of-a-zone.patch
mm-memory_hotplug-__offline_pages-fix-wrong-locking.patch
