The patch titled
Subject: include/linux/relay.h: fix percpu annotation in struct rchan
has been added to the -mm tree. Its filename is
relay-fix-percpu-annotation-in-struct-rchan.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/relay-fix-percpu-annotation-in-struct-rchan.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/relay-fix-percpu-annotation-in-struct-rchan.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
Subject: include/linux/relay.h: fix percpu annotation in struct rchan
The percpu member of this structure is declared as:
struct ... ** __percpu member;
So its type is:
__percpu pointer to pointer to struct ...
But looking at how it's used, its type should be:
pointer to __percpu pointer to struct ...
and it should thus be declared as:
struct ... * __percpu *member;
So fix the placement of '__percpu' in the definition of this
structures.
This silents a few Sparse's warnings like:
warning: incorrect type in initializer (different address spaces)
expected void const [noderef] <asn:3> *__vpp_verify
got struct sched_domain **
Link: http://lkml.kernel.org/r/20190118144902.79065-1-luc.vanoostenryck@xxxxxxxxx
Fixes: 017c59c04 ("relay: Use per CPU constructs for the relay channel buffer pointers")
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
Cc: Akash Goel <akash.goel@xxxxxxxxx>
Cc: Jens Axboe <axboe@xxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/relay.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/linux/relay.h~relay-fix-percpu-annotation-in-struct-rchan
+++ a/include/linux/relay.h
@@ -66,7 +66,7 @@ struct rchan
struct kref kref; /* channel refcount */
void *private_data; /* for user-defined data */
size_t last_toobig; /* tried to log event > subbuf size */
- struct rchan_buf ** __percpu buf; /* per-cpu channel buffers */
+ struct rchan_buf * __percpu *buf; /* per-cpu channel buffers */
int is_global; /* One global buffer ? */
struct list_head list; /* for channel list */
struct dentry *parent; /* parent dentry passed to open */
_
Patches currently in -mm which might be from luc.vanoostenryck@xxxxxxxxx are
relay-fix-percpu-annotation-in-struct-rchan.patch
