The patch titled
Subject: lib/test_kmod.c: potential double free in error handling
has been added to the -mm tree. Its filename is
lib-test_kmod-potential-double-free-in-error-handling.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-test_kmod-potential-double-free-in-error-handling.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-test_kmod-potential-double-free-in-error-handling.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: lib/test_kmod.c: potential double free in error handling
There is a copy and paste bug so we set "config->test_driver" to NULL
twice instead of setting "config->test_fs". Smatch complains that it
leads to a double free:
lib/test_kmod.c:840 __kmod_config_init() warn: 'config->test_fs' double freed
Link: http://lkml.kernel.org/r/20190121140011.GA14283@kadam
Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
lib/test_kmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/lib/test_kmod.c~lib-test_kmod-potential-double-free-in-error-handling
+++ a/lib/test_kmod.c
@@ -632,7 +632,7 @@ static void __kmod_config_free(struct te
config->test_driver = NULL;
kfree_const(config->test_fs);
- config->test_driver = NULL;
+ config->test_fs = NULL;
}
static void kmod_config_free(struct kmod_test_device *test_dev)
_
Patches currently in -mm which might be from dan.carpenter@xxxxxxxxxx are
lib-test_kmod-potential-double-free-in-error-handling.patch
rapidio-potential-oops-in-riocm_ch_listen.patch
