The patch titled
Subject: checkpatch: verify SPDX comment style
has been added to the -mm tree. Its filename is
checkpatch-verify-spdx-comment-style.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-verify-spdx-comment-style.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-verify-spdx-comment-style.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Joe Perches <joe@xxxxxxxxxxx>
Subject: checkpatch: verify SPDX comment style
Using SPDX commenting style // or /* is specified for various file types
in Documentation/process/license-rules.rst so add an appropriate test for
.[chsS] files because many proposed file additions and patches do not use
the correct style.
Link: http://lkml.kernel.org/r/8b02899853247a2c67669561761f354dd3bd110e.camel@xxxxxxxxxxx
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
--- a/scripts/checkpatch.pl~checkpatch-verify-spdx-comment-style
+++ a/scripts/checkpatch.pl
@@ -3039,6 +3039,14 @@ sub process {
$comment = '..';
}
+# check SPDX comment style for .[chsS] files
+ if ($realfile =~ /\.[chsS]$/ &&
+ $rawline =~ /SPDX-License-Identifier:/ &&
+ $rawline !~ /^\+\s*\Q$comment\E\s*/) {
+ WARN("SPDX_LICENSE_TAG",
+ "Improper SPDX comment style for '$realfile', please use '$comment' instead\n" . $herecurr);
+ }
+
if ($comment !~ /^$/ &&
$rawline !~ /^\+\Q$comment\E SPDX-License-Identifier: /) {
WARN("SPDX_LICENSE_TAG",
_
Patches currently in -mm which might be from joe@xxxxxxxxxxx are
checkpatch-dont-interpret-stack-dumps-as-commit-ids.patch
checkpatch-verify-spdx-comment-style.patch
