The patch titled
Subject: mm-memcg-fix-reclaim-deadlock-with-writeback-fix-checkpatch-fixes
has been added to the -mm tree. Its filename is
mm-memcg-fix-reclaim-deadlock-with-writeback-fix-checkpatch-fixes.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-memcg-fix-reclaim-deadlock-with-writeback-fix-checkpatch-fixes.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-memcg-fix-reclaim-deadlock-with-writeback-fix-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: mm-memcg-fix-reclaim-deadlock-with-writeback-fix-checkpatch-fixes
WARNING: please, no space before tabs
#29: FILE: mm/memory.c:3000:
+^I * ^I^I^I^Ilock_page(A)$
WARNING: please, no space before tabs
#30: FILE: mm/memory.c:3001:
+^I * ^I^I^I^ISetPageWriteback(A)$
WARNING: please, no space before tabs
#31: FILE: mm/memory.c:3002:
+^I * ^I^I^I^Iunlock_page(A)$
WARNING: please, no space before tabs
#33: FILE: mm/memory.c:3004:
+^I * ^I^I^I^Ilock_page(B)$
WARNING: please, no space before tabs
#37: FILE: mm/memory.c:3008:
+^I * ^I^I^I^ISetPageWriteback(B)$
WARNING: please, no space before tabs
#38: FILE: mm/memory.c:3009:
+^I * ^I^I^I^Iunlock_page(B)$
WARNING: please, no space before tabs
#39: FILE: mm/memory.c:3010:
+^I * ^I^I^I^I# flush A, B to clear the writeback$
WARNING: Missing Signed-off-by: line by nominal patch author 'Michal Hocko <mhocko@xxxxxxxxxx>'
total: 0 errors, 8 warnings, 19 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
./patches/mm-memcg-fix-reclaim-deadlock-with-writeback-fix.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Michal Hocko <mhocko@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/memory.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
--- a/mm/memory.c~mm-memcg-fix-reclaim-deadlock-with-writeback-fix-checkpatch-fixes
+++ a/mm/memory.c
@@ -2997,17 +2997,17 @@ static vm_fault_t __do_fault(struct vm_f
/*
* Preallocate pte before we take page_lock because this might lead to
* deadlocks for memcg reclaim which waits for pages under writeback:
- * lock_page(A)
- * SetPageWriteback(A)
- * unlock_page(A)
+ * lock_page(A)
+ * SetPageWriteback(A)
+ * unlock_page(A)
* lock_page(B)
- * lock_page(B)
+ * lock_page(B)
* pte_alloc_pne
* shrink_page_list
* wait_on_page_writeback(A)
- * SetPageWriteback(B)
- * unlock_page(B)
- * # flush A, B to clear the writeback
+ * SetPageWriteback(B)
+ * unlock_page(B)
+ * # flush A, B to clear the writeback
*/
if (pmd_none(*vmf->pmd) && !vmf->prealloc_pte) {
vmf->prealloc_pte = pte_alloc_one(vmf->vma->vm_mm, vmf->address);
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
mm-memcg-fix-reclaim-deadlock-with-writeback-fix-checkpatch-fixes.patch
arm-arch-arm-include-asm-pageh-needs-personalityh.patch
ocfs2-clear-zero-in-unaligned-direct-io-checkpatch-fixes.patch
mm.patch
mm-use-common-iterator-for-deferred_init_pages-and-deferred_free_pages-fix.patch
filemap-kill-page_cache_read-usage-in-filemap_fault-fix.patch
filemap-drop-the-mmap_sem-for-all-blocking-operations-checkpatch-fixes.patch
memory_hotplug-free-pages-as-higher-order-fix.patch
memory_hotplug-free-pages-as-higher-order-fix-fix.patch
fs-epoll-deal-with-wait_queue-only-once-fix.patch
autofs-improve-ioctl-sbi-checks-fix.patch
exec-separate-mm_anonpages-and-rlimit_stack-accounting-checkpatch-fixes.patch
ipc-allow-boot-time-extension-of-ipcmni-from-32k-to-8m-checkpatch-fixes.patch
scripts-atomic-check-atomicssh-dont-assume-that-scripts-are-executable.patch
mm-treewide-remove-unused-address-argument-from-pte_alloc-functions-v2-fix.patch
mm-convert-pg_balloon-to-pg_offline-fix.patch
fs-remove-caller-signal_pending-branch-predictions-fix.patch
mm-reuse-only-pte-mapped-ksm-page-in-do_wp_page-fix.patch
kernel-forkc-export-kernel_thread-to-modules.patch
slab-leaks3-default-y.patch
