The patch titled
knfsd: nfsd4: fix open permission checking
has been added to the -mm tree. Its filename is
knfsd-nfsd4-fix-open-permission-checking.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: knfsd: nfsd4: fix open permission checking
From: "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
We weren't actually checking for SHARE_ACCESS_WRITE, with the result that the
owner could open a non-writeable file for write!
Continue to allow DENY_WRITE only with write access.
Thanks to Jim Rees for reporting the bug.
Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxxxxxx>
Signed-off-by: Neil Brown <neilb@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/nfsd/nfs4proc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletion(-)
diff -puN fs/nfsd/nfs4proc.c~knfsd-nfsd4-fix-open-permission-checking fs/nfsd/nfs4proc.c
--- a/fs/nfsd/nfs4proc.c~knfsd-nfsd4-fix-open-permission-checking
+++ a/fs/nfsd/nfs4proc.c
@@ -78,8 +78,10 @@ do_open_permission(struct svc_rqst *rqst
if (open->op_share_access & NFS4_SHARE_ACCESS_READ)
accmode |= MAY_READ;
- if (open->op_share_deny & NFS4_SHARE_ACCESS_WRITE)
+ if (open->op_share_access & NFS4_SHARE_ACCESS_WRITE)
accmode |= (MAY_WRITE | MAY_TRUNC);
+ if (open->op_share_deny & NFS4_SHARE_DENY_WRITE)
+ accmode |= MAY_WRITE;
status = fh_verify(rqstp, current_fh, S_IFREG, accmode);
_
Patches currently in -mm which might be from bfields@xxxxxxxxxxxx are
knfsd-nfsd4-fix-owner-override-on-open.patch
knfsd-nfsd4-fix-open-permission-checking.patch
knfsd-nfsd4-fix-error-handling-in-nfsds-callback-client.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
