The patch titled
fuse: fix dereferencing dentry parent
has been added to the -mm tree. Its filename is
fuse-fix-dereferencing-dentry-parent.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: fuse: fix dereferencing dentry parent
From: Miklos Szeredi <miklos@xxxxxxxxxx>
There's no locking for ->d_revalidate, so fuse_dentry_revalidate() should use
dget_parent() instead of simply dereferencing ->d_parent.
Due to topology changes in the directory tree the parent could become negative
or be destroyed while being used. There hasn't been any reports about this
yet.
Signed-off-by: Miklos Szeredi <miklos@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
fs/fuse/dir.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletion(-)
diff -puN fs/fuse/dir.c~fuse-fix-dereferencing-dentry-parent fs/fuse/dir.c
--- a/fs/fuse/dir.c~fuse-fix-dereferencing-dentry-parent
+++ a/fs/fuse/dir.c
@@ -138,6 +138,7 @@ static int fuse_dentry_revalidate(struct
struct fuse_entry_out outarg;
struct fuse_conn *fc;
struct fuse_req *req;
+ struct dentry *parent;
/* Doesn't hurt to "reset" the validity timeout */
fuse_invalidate_entry_cache(entry);
@@ -151,8 +152,10 @@ static int fuse_dentry_revalidate(struct
if (IS_ERR(req))
return 0;
- fuse_lookup_init(req, entry->d_parent->d_inode, entry, &outarg);
+ parent = dget_parent(entry);
+ fuse_lookup_init(req, parent->d_inode, entry, &outarg);
request_send(fc, req);
+ dput(parent);
err = req->out.h.error;
/* Zero nodeid is same as -ENOENT */
if (!err && !outarg.nodeid)
_
Patches currently in -mm which might be from miklos@xxxxxxxxxx are
fuse-fix-hang-on-smp.patch
document-i_size_write-locking-rules.patch
fuse-locking-fix-for-nlookup.patch
fuse-fix-spurious-bug.patch
fuse-fix-handling-of-moved-directory.patch
fuse-fix-dereferencing-dentry-parent.patch
fuse-update-userspace-interface-to-version-78.patch
fuse-minor-cleanup-in-fuse_dentry_revalidate.patch
fuse-add-support-for-block-device-based-filesystems.patch
fuse-add-blksize-option.patch
fuse-add-bmap-support.patch
fuse-add-destroy-operation.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
