The patch titled
kallsyms: report consistent types for non-exported symbols
has been added to the -mm tree. Its filename is
kallsyms-report-consistent-types-for-non-exported.patch
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this
------------------------------------------------------
Subject: kallsyms: report consistent types for non-exported symbols
From: Adam B. Jerome <abj@xxxxxxxxxx>
Address incorrect symbol type information reported through /proc/kallsyms.
A lowercase character should designate the symbol as local (or
non-exported). An uppercase character should designate the symbol as
global (or external). Without this patch, some non-exported symbols are
incorrectly assigned an upper-case designation in /proc/kallsyms. This
patch corrects this condition by converting non-exported symbols types to
lower case when appropriate and eliminates the superfluous upcase_if_global
function.
Signed-off-by: Adam B. Jerome <abj@xxxxxxxxxx>
Cc: "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---
kernel/kallsyms.c | 13 +++++--------
1 files changed, 5 insertions(+), 8 deletions(-)
diff -puN kernel/kallsyms.c~kallsyms-report-consistent-types-for-non-exported kernel/kallsyms.c
--- a/kernel/kallsyms.c~kallsyms-report-consistent-types-for-non-exported
+++ a/kernel/kallsyms.c
@@ -20,6 +20,7 @@
#include <linux/proc_fs.h>
#include <linux/sched.h> /* for cond_resched */
#include <linux/mm.h>
+#include <linux/ctype.h>
#include <asm/sections.h>
@@ -301,13 +302,6 @@ struct kallsym_iter
char name[KSYM_NAME_LEN+1];
};
-/* Only label it "global" if it is exported. */
-static void upcase_if_global(struct kallsym_iter *iter)
-{
- if (is_exported(iter->name, iter->owner))
- iter->type += 'A' - 'a';
-}
-
static int get_ksymbol_mod(struct kallsym_iter *iter)
{
iter->owner = module_get_kallsym(iter->pos - kallsyms_num_syms,
@@ -316,7 +310,10 @@ static int get_ksymbol_mod(struct kallsy
if (iter->owner == NULL)
return 0;
- upcase_if_global(iter);
+ /* Label it "global" if it ix exported, "local" if not exported. */
+ iter->type = is_exported(iter->name, iter->owner)
+ ? toupper(iter->type) : tolower(iter->type);
+
return 1;
}
_
Patches currently in -mm which might be from abj@xxxxxxxxxx are
kernel-proc-kallsyms-reports-lower-case.patch
kallsyms-report-consistent-types-for-non-exported.patch
-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
