The patch titled
Subject: mm/gup.c: fix follow_page_mask() kerneldoc comment
has been added to the -mm tree. Its filename is
mm-gup-fix-follow_page_mask-kernel-doc-comment.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-gup-fix-follow_page_mask-kernel-doc-comment.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-gup-fix-follow_page_mask-kernel-doc-comment.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
Subject: mm/gup.c: fix follow_page_mask() kerneldoc comment
df06b37ffe5a ("mm/gup: cache dev_pagemap while pinning pages") modified
the signature of follow_page_mask() but left the parameter description
behind.
Update the description to make the code and comments agree again.
While at it, update formatting of the return value description to match
Documentation/doc-guide/kernel-doc.rst guidelines.
Link: http://lkml.kernel.org/r/1541603316-27832-1-git-send-email-rppt@xxxxxxxxxxxxx
Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/gup.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--- a/mm/gup.c~mm-gup-fix-follow_page_mask-kernel-doc-comment
+++ a/mm/gup.c
@@ -385,11 +385,17 @@ static struct page *follow_p4d_mask(stru
* @vma: vm_area_struct mapping @address
* @address: virtual address to look up
* @flags: flags modifying lookup behaviour
- * @page_mask: on output, *page_mask is set according to the size of the page
+ * @ctx: contains dev_pagemap for %ZONE_DEVICE memory pinning and a
+ * pointer to output page_mask
*
* @flags can have FOLL_ flags set, defined in <linux/mm.h>
*
- * Returns the mapped (struct page *), %NULL if no mapping exists, or
+ * When getting pages from ZONE_DEVICE memory, the @ctx->pgmap caches
+ * the device's dev_pagemap metadata to avoid repeating expensive lookups.
+ *
+ * On output, the @ctx->page_mask is set according to the size of the page.
+ *
+ * Return: the mapped (struct page *), %NULL if no mapping exists, or
* an error pointer if there is a mapping to something not represented
* by a page descriptor (see also vm_normal_page()).
*/
_
Patches currently in -mm which might be from rppt@xxxxxxxxxxxxx are
mm-gup-fix-follow_page_mask-kernel-doc-comment.patch
