The patch titled Subject: mm, slab: remove unnecessary unlikely() has been added to the -mm tree. Its filename is mm-slab-remove-unnecessary-unlikely.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-slab-remove-unnecessary-unlikely.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-slab-remove-unnecessary-unlikely.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Yangtao Li <tiny.windzz@xxxxxxxxx> Subject: mm, slab: remove unnecessary unlikely() WARN_ON() already contains an unlikely(), so it's not necessary to use unlikely. Link: http://lkml.kernel.org/r/20181104125028.3572-1-tiny.windzz@xxxxxxxxx Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx> Acked-by: Vlastimil Babka <vbabka@xxxxxxx> Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Christoph Lameter <cl@xxxxxxxxx> Cc: Pekka Enberg <penberg@xxxxxxxxxx> Cc: David Rientjes <rientjes@xxxxxxxxxx> Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/slab_common.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- a/mm/slab_common.c~mm-slab-remove-unnecessary-unlikely +++ a/mm/slab_common.c @@ -1029,10 +1029,8 @@ struct kmem_cache *kmalloc_slab(size_t s index = size_index[size_index_elem(size)]; } else { - if (unlikely(size > KMALLOC_MAX_CACHE_SIZE)) { - WARN_ON(1); + if (WARN_ON(size > KMALLOC_MAX_CACHE_SIZE)) return NULL; - } index = fls(size - 1); } _ Patches currently in -mm which might be from tiny.windzz@xxxxxxxxx are mm-slab-remove-unnecessary-unlikely.patch