The patch titled
Subject: include/linux/signal.h: mark expected switch fall-throughs
has been added to the -mm tree. Its filename is
signal-mark-expected-switch-fall-throughs.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/signal-mark-expected-switch-fall-throughs.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/signal-mark-expected-switch-fall-throughs.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
Subject: include/linux/signal.h: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.
Link: http://lkml.kernel.org/r/20181013114847.GA3160@xxxxxxxxxxxxxx
Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/signal.h | 6 ++++++
1 file changed, 6 insertions(+)
--- a/include/linux/signal.h~signal-mark-expected-switch-fall-throughs
+++ a/include/linux/signal.h
@@ -125,9 +125,11 @@ static inline void name(sigset_t *r, con
b3 = b->sig[3]; b2 = b->sig[2]; \
r->sig[3] = op(a3, b3); \
r->sig[2] = op(a2, b2); \
+ /* fall through */ \
case 2: \
a1 = a->sig[1]; b1 = b->sig[1]; \
r->sig[1] = op(a1, b1); \
+ /* fall through */ \
case 1: \
a0 = a->sig[0]; b0 = b->sig[0]; \
r->sig[0] = op(a0, b0); \
@@ -157,7 +159,9 @@ static inline void name(sigset_t *set)
switch (_NSIG_WORDS) { \
case 4: set->sig[3] = op(set->sig[3]); \
set->sig[2] = op(set->sig[2]); \
+ /* fall through */ \
case 2: set->sig[1] = op(set->sig[1]); \
+ /* fall through */ \
case 1: set->sig[0] = op(set->sig[0]); \
break; \
default: \
@@ -178,6 +182,7 @@ static inline void sigemptyset(sigset_t
memset(set, 0, sizeof(sigset_t));
break;
case 2: set->sig[1] = 0;
+ /* fall through */
case 1: set->sig[0] = 0;
break;
}
@@ -190,6 +195,7 @@ static inline void sigfillset(sigset_t *
memset(set, -1, sizeof(sigset_t));
break;
case 2: set->sig[1] = -1;
+ /* fall through */
case 1: set->sig[0] = -1;
break;
}
_
Patches currently in -mm which might be from gustavo@xxxxxxxxxxxxxx are
zsmalloc-fix-fall-through-annotation.patch
compat-mark-expected-switch-fall-throughs.patch
signal-mark-expected-switch-fall-throughs.patch
