The patch titled
Subject: kernel/panic.c: do not append newline to the stack protector panic string
has been added to the -mm tree. Its filename is
kernel-panic-do-not-append-newline-to-the-stack-protector-panic-string.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/kernel-panic-do-not-append-newline-to-the-stack-protector-panic-string.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/kernel-panic-do-not-append-newline-to-the-stack-protector-panic-string.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Borislav Petkov <bp@xxxxxxx>
Subject: kernel/panic.c: do not append newline to the stack protector panic string
... because panic() itself already does this. Otherwise you have
line-broken trailer:
[ 1.836965] ---[ end Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: pgd_alloc+0x29e/0x2a0
[ 1.836965] ]---
Link: http://lkml.kernel.org/r/20181008202901.7894-1-bp@xxxxxxxxx
Signed-off-by: Borislav Petkov <bp@xxxxxxx>
Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Cc: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
diff -puN kernel/panic.c~kernel-panic-do-not-append-newline-to-the-stack-protector-panic-string kernel/panic.c
--- a/kernel/panic.c~kernel-panic-do-not-append-newline-to-the-stack-protector-panic-string
+++ a/kernel/panic.c
@@ -631,7 +631,7 @@ device_initcall(register_warn_debugfs);
*/
__visible void __stack_chk_fail(void)
{
- panic("stack-protector: Kernel stack is corrupted in: %pB\n",
+ panic("stack-protector: Kernel stack is corrupted in: %pB",
__builtin_return_address(0));
}
EXPORT_SYMBOL(__stack_chk_fail);
_
Patches currently in -mm which might be from bp@xxxxxxx are
kernel-panic-do-not-append-newline-to-the-stack-protector-panic-string.patch
kernel-panic-filter-out-a-potential-trailing-newline.patch
