The patch titled
Subject: memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes
has been added to the -mm tree. Its filename is
memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes
ERROR: code indent should use tabs where possible
#244: FILE: arch/alpha/kernel/core_wildfire.c:114:
+ hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,$
WARNING: please, no spaces at the start of a line
#244: FILE: arch/alpha/kernel/core_wildfire.c:114:
+ hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,$
ERROR: code indent should use tabs where possible
#246: FILE: arch/alpha/kernel/core_wildfire.c:116:
+ hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,$
WARNING: please, no spaces at the start of a line
#246: FILE: arch/alpha/kernel/core_wildfire.c:116:
+ hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,$
ERROR: space required after that ';' (ctx:VxV)
#380: FILE: arch/ia64/kernel/mca.c:366:
+ (ia64_err_rec_t *)memblock_alloc(size, SMP_CACHE_BYTES);}
^
WARNING: line over 80 characters
#822: FILE: mm/percpu.c:1104:
+ chunk = memblock_alloc(sizeof(struct pcpu_chunk) + BITS_TO_LONGS(region_size >> PAGE_SHIFT),
WARNING: line over 80 characters
#837: FILE: mm/percpu.c:1116:
+ chunk->alloc_map = memblock_alloc(BITS_TO_LONGS(region_bits) * sizeof(chunk->alloc_map[0]),
WARNING: line over 80 characters
#839: FILE: mm/percpu.c:1118:
+ chunk->bound_map = memblock_alloc(BITS_TO_LONGS(region_bits + 1) * sizeof(chunk->bound_map[0]),
WARNING: line over 80 characters
#841: FILE: mm/percpu.c:1120:
+ chunk->md_blocks = memblock_alloc(pcpu_chunk_nr_blocks(chunk) * sizeof(chunk->md_blocks[0]),
total: 3 errors, 6 warnings, 618 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/memblock-stop-using-implicit-alignement-to-smp_cache_bytes.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
arch/alpha/kernel/core_wildfire.c | 4 ++--
mm/percpu.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
--- a/arch/alpha/kernel/core_wildfire.c~memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes
+++ a/arch/alpha/kernel/core_wildfire.c
@@ -111,9 +111,9 @@ wildfire_init_hose(int qbbno, int hoseno
* ??? We ought to scale window 3 memory.
*
*/
- hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,
+ hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,
SMP_CACHE_BYTES);
- hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,
+ hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,
SMP_CACHE_BYTES);
pci = WILDFIRE_pci(qbbno, hoseno);
--- a/mm/percpu.c~memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes
+++ a/mm/percpu.c
@@ -1101,7 +1101,8 @@ static struct pcpu_chunk * __init pcpu_a
region_size = ALIGN(start_offset + map_size, lcm_align);
/* allocate chunk */
- chunk = memblock_alloc(sizeof(struct pcpu_chunk) + BITS_TO_LONGS(region_size >> PAGE_SHIFT),
+ chunk = memblock_alloc(sizeof(struct pcpu_chunk) +
+ BITS_TO_LONGS(region_size >> PAGE_SHIFT),
SMP_CACHE_BYTES);
INIT_LIST_HEAD(&chunk->list);
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
fix-crash-on-ocfs2_duplicate_clusters_by_page-v5-checkpatch-fixes.patch
arm-arch-arm-include-asm-pageh-needs-personalityh.patch
fix-clusters-leak-in-ocfs2_defrag_extent-fix.patch
mm.patch
mmpage_alloc-pf_wq_worker-threads-must-sleep-at-should_reclaim_retry-fix.patch
sched-loadavg-consolidate-load_int-load_frac-calc_load-fix.patch
mm-mremap-downgrade-mmap_sem-to-read-when-shrinking-fix.patch
mm-brk-downgrade-mmap_sem-to-read-when-shrinking-fix.patch
mm-calculate-deferred-pages-after-skipping-mirrored-memory-fix.patch
list_lru-prefetch-neighboring-list-entries-before-acquiring-lock-fix.patch
lib-bitmapc-fix-remaining-space-computation-in-bitmap_print_to_pagebuf-fix.patch
lib-bitmapc-fix-remaining-space-computation-in-bitmap_print_to_pagebuf-fix-fix.patch
ipc-allow-boot-time-extension-of-ipcmni-from-32k-to-8m-checkpatch-fixes.patch
linux-next-rejects.patch
linux-next-git-rejects.patch
memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch-fixes.patch
kernel-forkc-export-kernel_thread-to-modules.patch
slab-leaks3-default-y.patch
