The patch titled
Subject: mm/slub: remove useless condition in deactivate_slab
has been added to the -mm tree. Its filename is
mm-slub-remove-useless-condition-in-deactivate_slab.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-slub-remove-useless-condition-in-deactivate_slab.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-remove-useless-condition-in-deactivate_slab.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Pingfan Liu <kernelfans@xxxxxxxxx>
Subject: mm/slub: remove useless condition in deactivate_slab
The var l should be used to reflect the original list, on which the page
should be. But c->page is not on any list. Furthermore, the current code
does not update the value of l. Hence remove the related logic
Link: http://lkml.kernel.org/r/1537941430-16217-1-git-send-email-kernelfans@xxxxxxxxx
Signed-off-by: Pingfan Liu <kernelfans@xxxxxxxxx>
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slub.c | 30 +++++++-----------------------
1 file changed, 7 insertions(+), 23 deletions(-)
--- a/mm/slub.c~mm-slub-remove-useless-condition-in-deactivate_slab
+++ a/mm/slub.c
@@ -1992,7 +1992,7 @@ static void deactivate_slab(struct kmem_
enum slab_modes { M_NONE, M_PARTIAL, M_FULL, M_FREE };
struct kmem_cache_node *n = get_node(s, page_to_nid(page));
int lock = 0;
- enum slab_modes l = M_NONE, m = M_NONE;
+ enum slab_modes m = M_NONE;
void *nextfree;
int tail = DEACTIVATE_TO_HEAD;
struct page new;
@@ -2088,30 +2088,14 @@ redo:
}
}
- if (l != m) {
-
- if (l == M_PARTIAL)
-
- remove_partial(n, page);
-
- else if (l == M_FULL)
-
- remove_full(s, n, page);
-
- if (m == M_PARTIAL) {
-
- add_partial(n, page, tail);
- stat(s, tail);
-
- } else if (m == M_FULL) {
-
- stat(s, DEACTIVATE_FULL);
- add_full(s, n, page);
-
- }
+ if (m == M_PARTIAL) {
+ add_partial(n, page, tail);
+ stat(s, tail);
+ } else if (m == M_FULL) {
+ stat(s, DEACTIVATE_FULL);
+ add_full(s, n, page);
}
- l = m;
if (!__cmpxchg_double_slab(s, page,
old.freelist, old.counters,
new.freelist, new.counters,
_
Patches currently in -mm which might be from kernelfans@xxxxxxxxx are
mm-slub-remove-useless-condition-in-deactivate_slab.patch
