The patch titled
Subject: mm/memory_hotplug.c: simplify node_states_check_changes_online
has been added to the -mm tree. Its filename is
mm-memory_hotplug-simplify-node_states_check_changes_online.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-memory_hotplug-simplify-node_states_check_changes_online.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-memory_hotplug-simplify-node_states_check_changes_online.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Oscar Salvador <osalvador@xxxxxxx>
Subject: mm/memory_hotplug.c: simplify node_states_check_changes_online
While looking at node_states_check_changes_online, I stumbled upon some
confusing things.
Right after entering the function, we find this:
if (N_MEMORY == N_NORMAL_MEMORY)
zone_last = ZONE_MOVABLE;
This is wrong.
N_MEMORY cannot really be equal to N_NORMAL_MEMORY.
My guess is that this wanted to be something like:
if (N_NORMAL_MEMORY == N_HIGH_MEMORY)
to check if we have CONFIG_HIGHMEM.
Later on, in the CONFIG_HIGHMEM block, we have:
if (N_MEMORY == N_HIGH_MEMORY)
zone_last = ZONE_MOVABLE;
Again, this is wrong, and will never be evaluated to true.
Besides removing these wrong if statements, I simplified the function a
bit.
Link: http://lkml.kernel.org/r/20180919100819.25518-5-osalvador@xxxxxxxxxxxxxxxxxx
Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
Reviewed-by: Pavel Tatashin <pavel.tatashin@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/memory_hotplug.c | 67 ++++++++++++++----------------------------
1 file changed, 23 insertions(+), 44 deletions(-)
--- a/mm/memory_hotplug.c~mm-memory_hotplug-simplify-node_states_check_changes_online
+++ a/mm/memory_hotplug.c
@@ -687,57 +687,36 @@ static void node_states_check_changes_on
struct zone *zone, struct memory_notify *arg)
{
int nid = zone_to_nid(zone);
- enum zone_type zone_last = ZONE_NORMAL;
/*
- * If we have HIGHMEM or movable node, node_states[N_NORMAL_MEMORY]
- * contains nodes which have zones of 0...ZONE_NORMAL,
- * set zone_last to ZONE_NORMAL.
- *
- * If we don't have HIGHMEM nor movable node,
- * node_states[N_NORMAL_MEMORY] contains nodes which have zones of
- * 0...ZONE_MOVABLE, set zone_last to ZONE_MOVABLE.
+ * zone_for_pfn_range() can only return a zone within
+ * (0..ZONE_NORMAL] or ZONE_MOVABLE.
+ * If the zone is within the range (0..ZONE_NORMAL],
+ * we need to check if:
+ * 1) We need to set the node for N_NORMAL_MEMORY
+ * 2) On CONFIG_HIGHMEM systems, we need to also set
+ * the node for N_HIGH_MEMORY.
+ * 3) On !CONFIG_HIGHMEM, we can disregard N_HIGH_MEMORY,
+ * as N_HIGH_MEMORY falls back to N_NORMAL_MEMORY.
*/
- if (N_MEMORY == N_NORMAL_MEMORY)
- zone_last = ZONE_MOVABLE;
- /*
- * if the memory to be online is in a zone of 0...zone_last, and
- * the zones of 0...zone_last don't have memory before online, we will
- * need to set the node to node_states[N_NORMAL_MEMORY] after
- * the memory is online.
- */
- if (zone_idx(zone) <= zone_last && !node_state(nid, N_NORMAL_MEMORY))
- arg->status_change_nid_normal = nid;
- else
- arg->status_change_nid_normal = -1;
-
-#ifdef CONFIG_HIGHMEM
- /*
- * If we have movable node, node_states[N_HIGH_MEMORY]
- * contains nodes which have zones of 0...ZONE_HIGHMEM,
- * set zone_last to ZONE_HIGHMEM.
- *
- * If we don't have movable node, node_states[N_NORMAL_MEMORY]
- * contains nodes which have zones of 0...ZONE_MOVABLE,
- * set zone_last to ZONE_MOVABLE.
- */
- zone_last = ZONE_HIGHMEM;
- if (N_MEMORY == N_HIGH_MEMORY)
- zone_last = ZONE_MOVABLE;
+ if (zone_idx(zone) <= ZONE_NORMAL) {
+ if (!node_state(nid, N_NORMAL_MEMORY))
+ arg->status_change_nid_normal = nid;
+ else
+ arg->status_change_nid_normal = -1;
- if (zone_idx(zone) <= zone_last && !node_state(nid, N_HIGH_MEMORY))
- arg->status_change_nid_high = nid;
- else
- arg->status_change_nid_high = -1;
-#else
- arg->status_change_nid_high = arg->status_change_nid_normal;
-#endif
+ if (IS_ENABLED(CONFIG_HIGHMEM)) {
+ if (!node_state(nid, N_HIGH_MEMORY))
+ arg->status_change_nid_high = nid;
+ } else
+ arg->status_change_nid_high = -1;
+ }
/*
- * if the node don't have memory befor online, we will need to
- * set the node to node_states[N_MEMORY] after the memory
- * is online.
+ * if the node doesn't have memory before onlining it, we will need
+ * to set the node to node_states[N_MEMORY] after the memory
+ * gets onlined.
*/
if (!node_state(nid, N_MEMORY))
arg->status_change_nid = nid;
_
Patches currently in -mm which might be from osalvador@xxxxxxx are
mm-page_alloc-clean-up-check_for_memory.patch
mm-memory_hotplug-spare-unnecessary-calls-to-node_set_state.patch
mm-memory_hotplug-tidy-up-node_states_clear_node.patch
mm-memory_hotplug-simplify-node_states_check_changes_online.patch
mm-memory_hotplug-simplify-node_states_check_changes_online-v2.patch
mm-memory_hotplug-clean-up-node_states_check_changes_offline.patch
mm-memory_hotplug-clean-up-node_states_check_changes_offline-v2.patch
