The patch titled
Subject: mm/memory_hotplug.c: tidy up node_states_clear_node()
has been added to the -mm tree. Its filename is
mm-memory_hotplug-tidy-up-node_states_clear_node.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-memory_hotplug-tidy-up-node_states_clear_node.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-memory_hotplug-tidy-up-node_states_clear_node.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Oscar Salvador <osalvador@xxxxxxx>
Subject: mm/memory_hotplug.c: tidy up node_states_clear_node()
node_states_clear has the following if statements:
if ((N_MEMORY != N_NORMAL_MEMORY) &&
(arg->status_change_nid_high >= 0))
...
if ((N_MEMORY != N_HIGH_MEMORY) &&
(arg->status_change_nid >= 0))
...
N_MEMORY can never be equal to neither N_NORMAL_MEMORY nor
N_HIGH_MEMORY.
Similar problem was found in [1].
Since this is wrong, let us get rid of it.
[1] https://patchwork.kernel.org/patch/10579155/
Link: http://lkml.kernel.org/r/20180919100819.25518-4-osalvador@xxxxxxxxxxxxxxxxxx
Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/memory_hotplug.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/mm/memory_hotplug.c~mm-memory_hotplug-tidy-up-node_states_clear_node
+++ a/mm/memory_hotplug.c
@@ -1590,12 +1590,10 @@ static void node_states_clear_node(int n
if (arg->status_change_nid_normal >= 0)
node_clear_state(node, N_NORMAL_MEMORY);
- if ((N_MEMORY != N_NORMAL_MEMORY) &&
- (arg->status_change_nid_high >= 0))
+ if (arg->status_change_nid_high >= 0)
node_clear_state(node, N_HIGH_MEMORY);
- if ((N_MEMORY != N_HIGH_MEMORY) &&
- (arg->status_change_nid >= 0))
+ if (arg->status_change_nid >= 0)
node_clear_state(node, N_MEMORY);
}
_
Patches currently in -mm which might be from osalvador@xxxxxxx are
mm-page_alloc-clean-up-check_for_memory.patch
mm-memory_hotplug-spare-unnecessary-calls-to-node_set_state.patch
mm-memory_hotplug-avoid-node_set-clear_staten_high_memory-when-config_highmem.patch
mm-memory_hotplug-tidy-up-node_states_clear_node.patch
mm-memory_hotplug-simplify-node_states_check_changes_online.patch
mm-memory_hotplug-clean-up-node_states_check_changes_offline.patch
