The patch titled
Subject: vfree-kvfree-add-debug-might-sleeps-fix
has been added to the -mm tree. Its filename is
vfree-kvfree-add-debug-might-sleeps-fix.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/vfree-kvfree-add-debug-might-sleeps-fix.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/vfree-kvfree-add-debug-might-sleeps-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
Subject: vfree-kvfree-add-debug-might-sleeps-fix
Seems like we need to drop might_sleep_if() from kvfree().
rcu_read_lock()
rhashtable_insert_rehash()
new_tbl = bucket_table_alloc(ht, size, GFP_ATOMIC | __GFP_NOWARN);
->kvmalloc();
bucket_table_free(new_tbl);
->kvfree()
rcu_read_unlock()
kvmalloc(..., GFP_ATOMIC) simply always kmalloc:
if ((flags & GFP_KERNEL) != GFP_KERNEL)
return kmalloc_node(size, flags, node);
So in the above case, kvfree() always frees kmalloced memory -> and never calls vfree().
Link: http://lkml.kernel.org/r/7e19e4df-b1a6-29bd-9ae7-0266d50bef1d@xxxxxxxxxxxxx
Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx>
Reported-by: kernel test robot <rong.a.chen@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/util.c | 2 --
1 file changed, 2 deletions(-)
--- a/mm/util.c~vfree-kvfree-add-debug-might-sleeps-fix
+++ a/mm/util.c
@@ -446,8 +446,6 @@ EXPORT_SYMBOL(kvmalloc_node);
*/
void kvfree(const void *addr)
{
- might_sleep_if(!in_interrupt());
-
if (is_vmalloc_addr(addr))
vfree(addr);
else
_
Patches currently in -mm which might be from aryabinin@xxxxxxxxxxxxx are
kvfree-fix-misleading-comment.patch
mm-vmalloc-improve-vfree-kerneldoc.patch
vfree-kvfree-add-debug-might-sleeps.patch
vfree-kvfree-add-debug-might-sleeps-fix.patch
