On Mon, 10 Sep 2018 14:28:19 -0700 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Mon, Sep 10, 2018 at 02:12:51PM -0700, Matthew Wilcox wrote: > > On Mon, Sep 10, 2018 at 01:54:12PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > > > The patch titled > > > Subject: include/linux/radix-tree.h: use DIV_ROUND_UP instead of reimplementing its function > > > has been added to the -mm tree. Its filename is > > > radix-tree-use-div_round_up-instead-of-reimplementing-its-function.patch > > > > > > From: zhong jiang <zhongjiang@xxxxxxxxxx> > > > Subject: include/linux/radix-tree.h: use DIV_ROUND_UP instead of reimplementing its function > > > > > > Link: http://lkml.kernel.org/r/1536564900-5944-1-git-send-email-zhongjiang@xxxxxxxxxx > > > Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> > > > Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx> > > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > urgh, what? i didn't see this. We're probably 2-3 kernel releases > > away from deleting this particular line of code (it's not scheduled for > > deletion next kernel release), so I don't mind, but it's pretty pointless > > to touch any radix tree code at this point. > > oh, wait. i was looking in the wrong tree, sorry. > > Andrew, please drop this patch, it conflicts with the XArray patches. > The XArray already had this: > > +#define XA_TAG_LONGS DIV_ROUND_UP(XA_CHUNK_SIZE, BITS_PER_LONG) > > so there's nothing to be gained from this patch. I'm not seeing any conflicts with anything in linux-next?