From: Davidlohr Bueso <dbueso@xxxxxxx> Subject: ipc/shm: properly return EIDRM in shm_lock() When getting rid of the general ipc_lock(), this was missed furthermore, making the comment around the ipc object validity check bogus. Under EIDRM conditions, callers will in turn not see the error and continue with the operation. Link: http://lkml.kernel.org/r/20180824030920.GD3677@linux-r8p5 Link: http://lkml.kernel.org/r/20180823024051.GC13343@shao2-debian Fixes: 82061c57ce9 ("ipc: drop ipc_lock()") Signed-off-by: Davidlohr Bueso <dbueso@xxxxxxx> Reported-by: kernel test robot <rong.a.chen@xxxxxxxxx> Cc: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- ipc/shm.c | 1 + 1 file changed, 1 insertion(+) --- a/ipc/shm.c~ipc-shm-properly-return-eidrm-in-shm_lock +++ a/ipc/shm.c @@ -199,6 +199,7 @@ static inline struct shmid_kernel *shm_l } ipc_unlock_object(ipcp); + ipcp = ERR_PTR(-EIDRM); err: rcu_read_unlock(); /* _
