The patch titled
Subject: proc/kcore: fix invalid memory access in multi-page read optimization
has been added to the -mm tree. Its filename is
proc-kcore-fix-invalid-memory-access-in-multi-page-read-optimization.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/proc-kcore-fix-invalid-memory-access-in-multi-page-read-optimization.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/proc-kcore-fix-invalid-memory-access-in-multi-page-read-optimization.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
Subject: proc/kcore: fix invalid memory access in multi-page read optimization
The 'm' kcore_list item can point to kclist_head, and it is incorrect to
look at m->addr / m->size in this case.
There is no choice but to run through the list of entries for every
address if we did not find any entry in the previous iteration
Link: http://lkml.kernel.org/r/1535515447-21167-1-git-send-email-asmadeus@xxxxxxxxxxxxx
Fixes: bf991c2231117 ("proc/kcore: optimize multiple page reads")
Signed-off-by: Dominique Martinet <asmadeus@xxxxxxxxxxxxx>
Cc: Omar Sandoval <osandov@xxxxxx>
Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Cc: Bhupesh Sharma <bhsharma@xxxxxxxxxx>
Cc: Eric Biederman <ebiederm@xxxxxxxxxxxx>
Cc: James Morse <james.morse@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/proc/kcore.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/fs/proc/kcore.c~proc-kcore-fix-invalid-memory-access-in-multi-page-read-optimization
+++ a/fs/proc/kcore.c
@@ -451,7 +451,8 @@ read_kcore(struct file *file, char __use
* If this is the first iteration or the address is not within
* the previous entry, search for a matching entry.
*/
- if (!m || start < m->addr || start >= m->addr + m->size) {
+ if (!m || &m->list == &kclist_head || start < m->addr ||
+ start >= m->addr + m->size) {
list_for_each_entry(m, &kclist_head, list) {
if (start >= m->addr &&
start < m->addr + m->size)
_
Patches currently in -mm which might be from asmadeus@xxxxxxxxxxxxx are
proc-kcore-fix-invalid-memory-access-in-multi-page-read-optimization.patch
