The patch titled
Subject: checkpatch: remove GCC_BINARY_CONSTANT warning
has been added to the -mm tree. Its filename is
checkpatch-remove-gcc_binary_constant-warning.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-remove-gcc_binary_constant-warning.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-remove-gcc_binary_constant-warning.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Christophe Leroy <christophe.leroy@xxxxxx>
Subject: checkpatch: remove GCC_BINARY_CONSTANT warning
This warning was there to avoid the use of 0bxxx values as they are not
supported by gcc prior to v4.3
Since cafa0010cd51f ("Raise the minimum required gcc version to 4.6"),
it's not an issue anymore and using such values can increase readability
of code.
Joe said:
: Seems sensible as the other compilers also support binary literals from
: relatively old versions.
: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3472.pdf
: https://software.intel.com/en-us/articles/c14-features-supported-by-intel-c-compiler
Link: http://lkml.kernel.org/r/392eeae782302ee8812a3c932a602035deed1609.1535351453.git.christophe.leroy@xxxxxx
Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 11 -----------
1 file changed, 11 deletions(-)
--- a/scripts/checkpatch.pl~checkpatch-remove-gcc_binary_constant-warning
+++ a/scripts/checkpatch.pl
@@ -4933,17 +4933,6 @@ sub process {
while ($line =~ m{($Constant|$Lval)}g) {
my $var = $1;
-#gcc binary extension
- if ($var =~ /^$Binary$/) {
- if (WARN("GCC_BINARY_CONSTANT",
- "Avoid gcc v4.3+ binary constant extension: <$var>\n" . $herecurr) &&
- $fix) {
- my $hexval = sprintf("0x%x", oct($var));
- $fixed[$fixlinenr] =~
- s/\b$var\b/$hexval/;
- }
- }
-
#CamelCase
if ($var !~ /^$Constant$/ &&
$var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
_
Patches currently in -mm which might be from christophe.leroy@xxxxxx are
checkpatch-remove-gcc_binary_constant-warning.patch
