The patch titled
Subject: checkpatch-dt-bindings-should-be-a-separate-patch-v2
has been added to the -mm tree. Its filename is
checkpatch-dt-bindings-should-be-a-separate-patch-v2.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-dt-bindings-should-be-a-separate-patch-v2.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-dt-bindings-should-be-a-separate-patch-v2.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Rob Herring <robh@xxxxxxxxxx>
Subject: checkpatch-dt-bindings-should-be-a-separate-patch-v2
add doc pointer to warning, simplify logic
Link: http://lkml.kernel.org/r/20180810170513.26284-1-robh@xxxxxxxxxx
Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
Cc: Andy Whitcroft <apw@xxxxxxxxxxxxx>
Cc: Joe Perches <joe@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
--- a/scripts/checkpatch.pl~checkpatch-dt-bindings-should-be-a-separate-patch-v2
+++ a/scripts/checkpatch.pl
@@ -2503,23 +2503,15 @@ sub process {
}
$checklicenseline = 1;
- if ($realfile !~ /MAINTAINERS/) {
- my $mixed = 0;
- if ($realfile =~ /(Documentation\/devicetree|include\/dt-bindings).*/) {
- if ($is_binding_patch == 0) {
- $mixed = 1;
- }
- $is_binding_patch = 1;
- } else {
- if ($is_binding_patch == 1) {
- $mixed = 1;
- }
- $is_binding_patch = 0;
- }
+ if ($realfile !~ /^MAINTAINERS/) {
+ my $last_binding_patch = $is_binding_patch;
+
+ $is_binding_patch = ($realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@);
- if ($mixed == 1) {
+ if (($last_binding_patch != -1) &&
+ ($last_binding_patch ^ $is_binding_patch)) {
WARN("DT_SPLIT_BINDING_PATCH",
- "DT binding docs and includes should be a separate patch\n");
+ "DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.txt");
}
}
_
Patches currently in -mm which might be from robh@xxxxxxxxxx are
checkpatch-dt-bindings-should-be-a-separate-patch.patch
checkpatch-dt-bindings-should-be-a-separate-patch-v2.patch
