The patch titled
Subject: zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes
has been added to the -mm tree. Its filename is
zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes
ERROR: code indent should use tabs where possible
#28: FILE: drivers/block/zram/zram_drv.c:405:
+ ^I * With writeback feature, zram does asynchronous IO so it's no longer$
WARNING: please, no space before tabs
#28: FILE: drivers/block/zram/zram_drv.c:405:
+ ^I * With writeback feature, zram does asynchronous IO so it's no longer$
ERROR: code indent should use tabs where possible
#29: FILE: drivers/block/zram/zram_drv.c:406:
+ ^I * synchronous device so let's remove synchronous io flag. Othewise,$
WARNING: please, no space before tabs
#29: FILE: drivers/block/zram/zram_drv.c:406:
+ ^I * synchronous device so let's remove synchronous io flag. Othewise,$
ERROR: code indent should use tabs where possible
#32: FILE: drivers/block/zram/zram_drv.c:409:
+ ^I * Furthermore, when the IO function returns(e.g., swap_readpage),$
WARNING: please, no space before tabs
#32: FILE: drivers/block/zram/zram_drv.c:409:
+ ^I * Furthermore, when the IO function returns(e.g., swap_readpage),$
ERROR: code indent should use tabs where possible
#33: FILE: drivers/block/zram/zram_drv.c:410:
+ ^I * upper layer expects IO was done so it could deallocate the page$
WARNING: please, no space before tabs
#33: FILE: drivers/block/zram/zram_drv.c:410:
+ ^I * upper layer expects IO was done so it could deallocate the page$
ERROR: code indent should use tabs where possible
#34: FILE: drivers/block/zram/zram_drv.c:411:
+ ^I * freely but in fact, IO is going on so finally could cause$
WARNING: please, no space before tabs
#34: FILE: drivers/block/zram/zram_drv.c:411:
+ ^I * freely but in fact, IO is going on so finally could cause$
ERROR: code indent should use tabs where possible
#35: FILE: drivers/block/zram/zram_drv.c:412:
+ ^I * use-after-free when the IO is really done.$
WARNING: please, no space before tabs
#35: FILE: drivers/block/zram/zram_drv.c:412:
+ ^I * use-after-free when the IO is really done.$
ERROR: code indent should use tabs where possible
#36: FILE: drivers/block/zram/zram_drv.c:413:
+ ^I */$
WARNING: please, no space before tabs
#36: FILE: drivers/block/zram/zram_drv.c:413:
+ ^I */$
total: 7 errors, 7 warnings, 16 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
./patches/zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Minchan Kim <minchan@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
diff -puN drivers/block/zram/zram_drv.c~zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes drivers/block/zram/zram_drv.c
--- a/drivers/block/zram/zram_drv.c~zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes
+++ a/drivers/block/zram/zram_drv.c
@@ -402,15 +402,15 @@ static ssize_t backing_dev_store(struct
zram->bitmap = bitmap;
zram->nr_pages = nr_pages;
/*
- * With writeback feature, zram does asynchronous IO so it's no longer
- * synchronous device so let's remove synchronous io flag. Othewise,
+ * With writeback feature, zram does asynchronous IO so it's no longer
+ * synchronous device so let's remove synchronous io flag. Othewise,
* upper layer(e.g., swap) could wait IO completion rather than
* (submit and return), which will cause system sluggish.
- * Furthermore, when the IO function returns(e.g., swap_readpage),
- * upper layer expects IO was done so it could deallocate the page
- * freely but in fact, IO is going on so finally could cause
- * use-after-free when the IO is really done.
- */
+ * Furthermore, when the IO function returns(e.g., swap_readpage),
+ * upper layer expects IO was done so it could deallocate the page
+ * freely but in fact, IO is going on so finally could cause
+ * use-after-free when the IO is really done.
+ */
zram->disk->queue->backing_dev_info->capabilities &=
~BDI_CAP_SYNCHRONOUS_IO;
up_write(&zram->init_lock);
_
Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are
i-need-old-gcc.patch
zram-remove-bd_cap_synchronous_io-with-writeback-feature-v2-checkpatch-fixes.patch
arm-arch-arm-include-asm-pageh-needs-personalityh.patch
ocfs2-return-erofs-when-filesystem-becomes-read-only-checkpatch-fixes.patch
mm.patch
tools-modifying-page-types-to-include-shared-map-counts-checkpatch-fixes.patch
tools-modifying-page-types-to-include-shared-map-counts-fix-checkpatch-fixes.patch
tools-adding-support-for-idle-page-tracking-to-tool-fix.patch
mm-drop-vm_bug_on-from-__get_free_pages-fix.patch
mm-list_lruc-fold-__list_lru_count_one-into-its-caller.patch
mm-fadvise-fix-signed-overflow-ubsan-complaint-fix.patch
mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch
mm-sparse-optimize-memmap-allocation-during-sparse_init-checkpatch-fixes.patch
mm-sparse-abstract-sparse-buffer-allocations-fix.patch
mm-sparse-abstract-sparse-buffer-allocations-fix-fix.patch
mm-soft-offline-close-the-race-against-page-allocation-fix.patch
mm-oom-distinguish-blockable-mode-for-mmu-notifiers-checkpatch-fixes.patch
mm-oom-distinguish-blockable-mode-for-mmu-notifiers-fix.patch
mm-zero-out-the-vma-in-vma_init.patch
mm-calculate-deferred-pages-after-skipping-mirrored-memory-fix.patch
list_lru-prefetch-neighboring-list-entries-before-acquiring-lock-fix.patch
proc-kcore-hold-lock-during-read-fix.patch
kernel-hung_taskc-allow-to-set-checking-interval-separately-from-timeout-fix.patch
fs-epoll-robustify-irq-safety-with-lockdep_assert_irqs_enabled-fix.patch
checkpatch-check-for-if-0-if-1-fix.patch
checkpatch-warn-when-a-patch-doesnt-have-a-description-fix.patch
fs-epoll-simply-config_net_rx_busy_poll-ifdefery-fix.patch
linux-next-rejects.patch
mm-change-return-type-int-to-vm_fault_t-for-fault-handlers-fix.patch
kernel-forkc-export-kernel_thread-to-modules.patch
slab-leaks3-default-y.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
