The patch titled Subject: memcg: add comment to mem_cgroup_css_online() has been added to the -mm tree. Its filename is mm-assign-memcg-aware-shrinkers-bitmap-to-memcg-fix.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-assign-memcg-aware-shrinkers-bitmap-to-memcg-fix.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-assign-memcg-aware-shrinkers-bitmap-to-memcg-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> Subject: memcg: add comment to mem_cgroup_css_online() Explain relationships between allocation and expanding. Link: http://lkml.kernel.org/r/521f9e5f-c436-b388-fe83-4dc870bfb489@xxxxxxxxxxxxx Signed-off-by: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> Suggested-by: Vladimir Davydov <vdavydov.dev@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/memcontrol.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/mm/memcontrol.c~mm-assign-memcg-aware-shrinkers-bitmap-to-memcg-fix +++ a/mm/memcontrol.c @@ -4469,6 +4469,11 @@ static int mem_cgroup_css_online(struct { struct mem_cgroup *memcg = mem_cgroup_from_css(css); + /* + * A memcg must be visible for memcg_expand_shrinker_maps() + * by the time the maps are allocated. So, we allocate maps + * here, when for_each_mem_cgroup() can't skip it. + */ if (memcg_alloc_shrinker_maps(memcg)) { mem_cgroup_id_remove(memcg); return -ENOMEM; _ Patches currently in -mm which might be from ktkhai@xxxxxxxxxxxxx are memcg-remove-memcg_cgroup-id-from-idr-on-mem_cgroup_css_alloc-failure.patch list_lru-combine-code-under-the-same-define.patch mm-introduce-config_memcg_kmem-as-combination-of-config_memcg-config_slob.patch mm-assign-id-to-every-memcg-aware-shrinker.patch mm-assign-id-to-every-memcg-aware-shrinker-v9.patch memcg-move-up-for_each_mem_cgroup-_tree-defines.patch mm-assign-memcg-aware-shrinkers-bitmap-to-memcg.patch mm-assign-memcg-aware-shrinkers-bitmap-to-memcg-v9.patch mm-assign-memcg-aware-shrinkers-bitmap-to-memcg-fix.patch mm-refactoring-in-workingset_init.patch mm-refactoring-in-workingset_init-v9.patch fs-refactoring-in-alloc_super.patch fs-propagate-shrinker-id-to-list_lru.patch list_lru-add-memcg-argument-to-list_lru_from_kmem.patch list_lru-pass-dst_memcg-argument-to-memcg_drain_list_lru_node.patch list_lru-pass-lru-argument-to-memcg_drain_list_lru_node.patch mm-export-mem_cgroup_is_root.patch mm-set-bit-in-memcg-shrinker-bitmap-on-first-list_lru-item-apearance.patch mm-set-bit-in-memcg-shrinker-bitmap-on-first-list_lru-item-apearance-v9.patch mm-iterate-only-over-charged-shrinkers-during-memcg-shrink_slab.patch mm-iterate-only-over-charged-shrinkers-during-memcg-shrink_slab-v9.patch mm-add-shrink_empty-shrinker-methods-return-value.patch mm-clear-shrinker-bit-if-there-are-no-objects-related-to-memcg.patch mm-clear-shrinker-bit-if-there-are-no-objects-related-to-memcg-v9.patch mm-move-check-for-shrinker_numa_aware-to-do_shrink_slab.patch mm-keep-int-fields-in-struct-shrink_control-together.patch mm-make-flags-of-unsigned-type-in-struct-shrinker.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html