The patch titled
Subject: lib-add-crc64-calculation-routines-v5
has been added to the -mm tree. Its filename is
lib-add-crc64-calculation-routines-v5.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/lib-add-crc64-calculation-routines-v5.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/lib-add-crc64-calculation-routines-v5.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Coly Li <colyli@xxxxxxx>
Subject: lib-add-crc64-calculation-routines-v5
fix review comments from v4
Link: http://lkml.kernel.org/r/20180726053352.2781-2-colyli@xxxxxxx
Signed-off-by: Coly Li <colyli@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
include/linux/crc64.h | 2 +-
lib/crc64.c | 6 +++---
lib/gen_crc64table.c | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff -puN include/linux/crc64.h~lib-add-crc64-calculation-routines-v5 include/linux/crc64.h
--- a/include/linux/crc64.h~lib-add-crc64-calculation-routines-v5
+++ a/include/linux/crc64.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0 */
/*
- * See lib/crc64.c for the related specification and polynomical arithmetic.
+ * See lib/crc64.c for the related specification and polynomial arithmetic.
*/
#ifndef _LINUX_CRC64_H
#define _LINUX_CRC64_H
diff -puN lib/crc64.c~lib-add-crc64-calculation-routines-v5 lib/crc64.c
--- a/lib/crc64.c~lib-add-crc64-calculation-routines-v5
+++ a/lib/crc64.c
@@ -12,7 +12,7 @@
* from,
* http://www.ross.net/crc/download/crc_v3.txt
*
- * crc64table[256] is the lookup table of a table-driver 64-bit CRC
+ * crc64table[256] is the lookup table of a table-driven 64-bit CRC
* calculation, which is generated by gen_crc64table.c in kernel build
* time. The polynomial of crc64 arithmetic is from ECMA-182 specification
* as well, which is defined as,
@@ -35,8 +35,8 @@ MODULE_LICENSE("GPL v2");
/**
* crc64_be - Calculate bitwise big-endian ECMA-182 CRC64
- * @crc: seed value for computation. 0 for a new CRC computing, or the
- * previous crc64 value if computing incrementally.
+ * @crc: seed value for computation. 0 or (u64)~0 for a new CRC calculation,
+ or the previous crc64 value if computing incrementally.
* @p: pointer to buffer over which CRC64 is run
* @len: length of buffer @p
*/
diff -puN lib/gen_crc64table.c~lib-add-crc64-calculation-routines-v5 lib/gen_crc64table.c
--- a/lib/gen_crc64table.c~lib-add-crc64-calculation-routines-v5
+++ a/lib/gen_crc64table.c
@@ -1,13 +1,13 @@
// SPDX-License-Identifier: GPL-2.0
/*
- * Generate lookup table for the talbe-driven CRC64 calculation.
+ * Generate lookup table for the table-driven CRC64 calculation.
*
* gen_crc64table is executed in kernel build time and generates
* lib/crc64table.h. This header is included by lib/crc64.c for
- * the table-driver CRC64 calculation.
+ * the table-driven CRC64 calculation.
*
* See lib/crc64.c for more information about which specification
- * and polynomical arithmetic that gen_crc64table.c follows to
+ * and polynomial arithmetic that gen_crc64table.c follows to
* generate the lookup table.
*
* Copyright 2018 SUSE Linux.
@@ -20,7 +20,7 @@
#define CRC64_ECMA182_POLY 0x42F0E1EBA9EA3693ULL
-static int64_t crc64_table[256] = {0};
+static uint64_t crc64_table[256] = {0};
static void generate_crc64_table(void)
{
_
Patches currently in -mm which might be from colyli@xxxxxxx are
lib-add-crc64-calculation-routines.patch
lib-add-crc64-calculation-routines-v5.patch
bcache-use-routines-from-lib-crc64c-for-crc64-calculation.patch
lib-test_crc-add-test-cases-for-crc-calculation.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
