The patch titled
Subject: fs/super.c: fix double prealloc_shrinker() in sget_fc()
has been added to the -mm tree. Its filename is
fs-fix-double-prealloc_shrinker-in-sget_fc.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/fs-fix-double-prealloc_shrinker-in-sget_fc.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/fs-fix-double-prealloc_shrinker-in-sget_fc.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx>
Subject: fs/super.c: fix double prealloc_shrinker() in sget_fc()
I'm observing "KASAN: use-after-free Read in shrink_slab" on recent
linux-next in the code I've added:
https://syzkaller.appspot.com/bug?id=91767fc6346a4b9e0309a8cd7e2f356c434450b9
It seems to be not related to my patchset, since there is a problem with
double preallocation of shrinker. We should use
register_shrinker_prepared() in sget_fc(), since shrinker is already
allocated in alloc_super().
Link: http://lkml.kernel.org/r/153131984019.24777.15284245961241666054.stgit@localhost.localdomain
Signed-off-by: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx>
Cc: David Howells <dhowells@xxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN fs/super.c~fs-fix-double-prealloc_shrinker-in-sget_fc fs/super.c
--- a/fs/super.c~fs-fix-double-prealloc_shrinker-in-sget_fc
+++ a/fs/super.c
@@ -551,7 +551,7 @@ retry:
hlist_add_head(&s->s_instances, &s->s_type->fs_supers);
spin_unlock(&sb_lock);
get_filesystem(s->s_type);
- register_shrinker(&s->s_shrink);
+ register_shrinker_prepared(&s->shrinker);
return s;
}
EXPORT_SYMBOL(sget_fc);
_
Patches currently in -mm which might be from ktkhai@xxxxxxxxxxxxx are
memcg-remove-memcg_cgroup-id-from-idr-on-mem_cgroup_css_alloc-failure.patch
list_lru-combine-code-under-the-same-define.patch
mm-introduce-config_memcg_kmem-as-combination-of-config_memcg-config_slob.patch
mm-assign-id-to-every-memcg-aware-shrinker.patch
mm-assign-id-to-every-memcg-aware-shrinker-v9.patch
memcg-move-up-for_each_mem_cgroup-_tree-defines.patch
mm-assign-memcg-aware-shrinkers-bitmap-to-memcg.patch
mm-assign-memcg-aware-shrinkers-bitmap-to-memcg-v9.patch
mm-refactoring-in-workingset_init.patch
mm-refactoring-in-workingset_init-v9.patch
fs-refactoring-in-alloc_super.patch
fs-propagate-shrinker-id-to-list_lru.patch
list_lru-add-memcg-argument-to-list_lru_from_kmem.patch
list_lru-pass-dst_memcg-argument-to-memcg_drain_list_lru_node.patch
list_lru-pass-lru-argument-to-memcg_drain_list_lru_node.patch
mm-export-mem_cgroup_is_root.patch
mm-set-bit-in-memcg-shrinker-bitmap-on-first-list_lru-item-apearance.patch
mm-set-bit-in-memcg-shrinker-bitmap-on-first-list_lru-item-apearance-v9.patch
mm-iterate-only-over-charged-shrinkers-during-memcg-shrink_slab.patch
mm-iterate-only-over-charged-shrinkers-during-memcg-shrink_slab-v9.patch
mm-add-shrink_empty-shrinker-methods-return-value.patch
mm-clear-shrinker-bit-if-there-are-no-objects-related-to-memcg.patch
mm-clear-shrinker-bit-if-there-are-no-objects-related-to-memcg-v9.patch
fs-fix-double-prealloc_shrinker-in-sget_fc.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
