The patch titled Subject: mm-fadvise-fix-signed-overflow-ubsan-complaint-fix has been added to the -mm tree. Its filename is mm-fadvise-fix-signed-overflow-ubsan-complaint-fix.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-fadvise-fix-signed-overflow-ubsan-complaint-fix.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-fadvise-fix-signed-overflow-ubsan-complaint-fix.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Subject: mm-fadvise-fix-signed-overflow-ubsan-complaint-fix add comment explaining the casts Cc: Alexander Potapenko <glider@xxxxxxxxxx> Cc: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx> Cc: <icytxw@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- diff -puN mm/fadvise.c~mm-fadvise-fix-signed-overflow-ubsan-complaint-fix mm/fadvise.c --- a/mm/fadvise.c~mm-fadvise-fix-signed-overflow-ubsan-complaint-fix +++ a/mm/fadvise.c @@ -72,7 +72,11 @@ int ksys_fadvise64_64(int fd, loff_t off goto out; } - /* Careful about overflows. Len == 0 means "as much as possible" */ + /* + * Careful about overflows. Len == 0 means "as much as possible". Use + * unsigned math because signed overflows are undefined and UBSan + * complains. + */ endbyte = (u64)offset + (u64)len; if (!len || endbyte < len) endbyte = -1; _ Patches currently in -mm which might be from akpm@xxxxxxxxxxxxxxxxxxxx are i-need-old-gcc.patch arm-arch-arm-include-asm-pageh-needs-personalityh.patch ocfs2-return-erofs-when-filesystem-becomes-read-only-checkpatch-fixes.patch mm.patch tools-modifying-page-types-to-include-shared-map-counts-checkpatch-fixes.patch tools-adding-support-for-idle-page-tracking-to-tool-fix.patch mm-drop-vm_bug_on-from-__get_free_pages-fix.patch mm-list_lruc-fold-__list_lru_count_one-into-its-caller.patch mm-fadvise-fix-signed-overflow-ubsan-complaint-fix.patch mm-sparsemem-defer-the-ms-section_mem_map-clearing-fix.patch list_lru-prefetch-neighboring-list-entries-before-acquiring-lock-fix.patch mm-oom-cgroup-aware-oom-killer-fix.patch mm-oom-cgroup-aware-oom-killer-fix-2.patch mm-oom-docs-describe-the-cgroup-aware-oom-killer-fix-2-fix.patch kernel-hung_taskc-allow-to-set-checking-interval-separately-from-timeout-fix.patch linux-next-rejects.patch kernel-forkc-export-kernel_thread-to-modules.patch slab-leaks3-default-y.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html