The patch titled
Subject: Revert "lib/test_printf.c: call wait_for_random_bytes() before plain %p tests"
has been added to the -mm tree. Its filename is
revert-lib-test_printfc-call-wait_for_random_bytes-before-plain-%p-tests.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/revert-lib-test_printfc-call-wait_for_random_bytes-before-plain-%25p-tests.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/revert-lib-test_printfc-call-wait_for_random_bytes-before-plain-%25p-tests.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Petr Mladek <pmladek@xxxxxxxx>
Subject: Revert "lib/test_printf.c: call wait_for_random_bytes() before plain %p tests"
Revert ee410f15b1418f2f442 ("lib/test_printf.c: call
wait_for_random_bytes() before plain %p tests").
It might prevent the machine from booting. It would wait for enough
randomness at the very beginning of kernel_init(). But there is basically
nothing running in parallel that would help to produce any randomness.
Link: http://lkml.kernel.org/r/20180625120454.rtf7ram4euvgdc6w@xxxxxxxxxxxxxxx
Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
Reported-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
Cc: Thierry Escande <thierry.escande@xxxxxxxxxx>
Cc: David Miller <davem@xxxxxxxxxxxxx>
Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
Cc: "Tobin C . Harding" <me@xxxxxxxx>
Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
diff -puN lib/test_printf.c~revert-lib-test_printfc-call-wait_for_random_bytes-before-plain-%p-tests lib/test_printf.c
--- a/lib/test_printf.c~revert-lib-test_printfc-call-wait_for_random_bytes-before-plain-%p-tests
+++ a/lib/test_printf.c
@@ -260,13 +260,6 @@ plain(void)
{
int err;
- /*
- * Make sure crng is ready. Otherwise we get "(ptrval)" instead
- * of a hashed address when printing '%p' in plain_hash() and
- * plain_format().
- */
- wait_for_random_bytes();
-
err = plain_hash();
if (err) {
pr_warn("plain 'p' does not appear to be hashed\n");
_
Patches currently in -mm which might be from pmladek@xxxxxxxx are
revert-lib-test_printfc-call-wait_for_random_bytes-before-plain-%p-tests.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
