The patch titled
Subject: signal: make kill_ok_by_cred() return bool
has been added to the -mm tree. Its filename is
signal-make-kill_ok_by_cred-return-bool.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/signal-make-kill_ok_by_cred-return-bool.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/signal-make-kill_ok_by_cred-return-bool.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Christian Brauner <christian@xxxxxxxxxx>
Subject: signal: make kill_ok_by_cred() return bool
kill_ok_by_cred() already behaves like a boolean function. Let's actually
declare it as such too.
Link: http://lkml.kernel.org/r/20180602103653.18181-7-christian@xxxxxxxxxx
Signed-off-by: Christian Brauner <christian@xxxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: James Morris <james.morris@xxxxxxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Stephen Smalley <sds@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
kernel/signal.c | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff -puN kernel/signal.c~signal-make-kill_ok_by_cred-return-bool kernel/signal.c
--- a/kernel/signal.c~signal-make-kill_ok_by_cred-return-bool
+++ a/kernel/signal.c
@@ -717,21 +717,16 @@ static inline bool si_fromuser(const str
/*
* called with RCU read lock from check_kill_permission()
*/
-static int kill_ok_by_cred(struct task_struct *t)
+static bool kill_ok_by_cred(struct task_struct *t)
{
const struct cred *cred = current_cred();
const struct cred *tcred = __task_cred(t);
- if (uid_eq(cred->euid, tcred->suid) ||
- uid_eq(cred->euid, tcred->uid) ||
- uid_eq(cred->uid, tcred->suid) ||
- uid_eq(cred->uid, tcred->uid))
- return 1;
-
- if (ns_capable(tcred->user_ns, CAP_KILL))
- return 1;
-
- return 0;
+ return uid_eq(cred->euid, tcred->suid) ||
+ uid_eq(cred->euid, tcred->uid) ||
+ uid_eq(cred->uid, tcred->suid) ||
+ uid_eq(cred->uid, tcred->uid) ||
+ ns_capable(tcred->user_ns, CAP_KILL);
}
/*
_
Patches currently in -mm which might be from christian@xxxxxxxxxx are
signal-make-force_sigsegv-void.patch
signal-make-kill_as_cred_perm-return-bool.patch
signal-make-may_ptrace_stop-return-bool.patch
signal-make-do_sigpending-void.patch
signal-simplify-rt_sigaction.patch
signal-make-kill_ok_by_cred-return-bool.patch
signal-make-sig_handler_ignored-return-bool.patch
signal-make-sig_task_ignored-return-bool.patch
signal-make-sig_ignored-return-bool.patch
signal-make-has_pending_signals-return-bool.patch
signal-make-recalc_sigpending_tsk-return-bool.patch
signal-make-unhandled_signal-return-bool.patch
signal-make-flush_sigqueue_mask-void.patch
signal-make-wants_signal-return-bool.patch
signal-make-legacy_queue-return-bool.patch
signal-make-sigkill_pending-return-bool.patch
signal-make-get_signal-return-bool.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
