From: Alexey Dobriyan <adobriyan@xxxxxxxxx> Subject: proc: use "unsigned int" in proc_fill_cache() All those lengths are unsigned as they should be. Link: http://lkml.kernel.org/r/20180423213751.GC9043@avx2 Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx> Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- fs/proc/base.c | 6 +++--- fs/proc/fd.c | 2 +- fs/proc/internal.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff -puN fs/proc/base.c~proc-use-unsigned-int-in-proc_fill_cache fs/proc/base.c --- a/fs/proc/base.c~proc-use-unsigned-int-in-proc_fill_cache +++ a/fs/proc/base.c @@ -1846,7 +1846,7 @@ const struct dentry_operations pid_dentr * by stat. */ bool proc_fill_cache(struct file *file, struct dir_context *ctx, - const char *name, int len, + const char *name, unsigned int len, instantiate_t instantiate, struct task_struct *task, const void *ptr) { struct dentry *child, *dir = file->f_path.dentry; @@ -3222,7 +3222,7 @@ int proc_pid_readdir(struct file *file, iter.task; iter.tgid += 1, iter = next_tgid(ns, iter)) { char name[10 + 1]; - int len; + unsigned int len; cond_resched(); if (!has_pid_permissions(ns, iter.task, HIDEPID_INVISIBLE)) @@ -3549,7 +3549,7 @@ static int proc_task_readdir(struct file task; task = next_tid(task), ctx->pos++) { char name[10 + 1]; - int len; + unsigned int len; tid = task_pid_nr_ns(task, ns); len = snprintf(name, sizeof(name), "%u", tid); if (!proc_fill_cache(file, ctx, name, len, diff -puN fs/proc/fd.c~proc-use-unsigned-int-in-proc_fill_cache fs/proc/fd.c --- a/fs/proc/fd.c~proc-use-unsigned-int-in-proc_fill_cache +++ a/fs/proc/fd.c @@ -248,7 +248,7 @@ static int proc_readfd_common(struct fil struct file *f; struct fd_data data; char name[10 + 1]; - int len; + unsigned int len; f = fcheck_files(files, fd); if (!f) diff -puN fs/proc/internal.h~proc-use-unsigned-int-in-proc_fill_cache fs/proc/internal.h --- a/fs/proc/internal.h~proc-use-unsigned-int-in-proc_fill_cache +++ a/fs/proc/internal.h @@ -163,7 +163,7 @@ extern loff_t mem_lseek(struct file *, l /* Lookups */ typedef struct dentry *instantiate_t(struct dentry *, struct task_struct *, const void *); -extern bool proc_fill_cache(struct file *, struct dir_context *, const char *, int, +bool proc_fill_cache(struct file *, struct dir_context *, const char *, unsigned int, instantiate_t, struct task_struct *, const void *); /* _ -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
