The patch titled
Subject: mm: fix the NULL mapping case in __isolate_lru_page()
has been added to the -mm tree. Its filename is
mm-fix-the-null-mapping-case-in-__isolate_lru_page.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-fix-the-null-mapping-case-in-__isolate_lru_page.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-fix-the-null-mapping-case-in-__isolate_lru_page.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Hugh Dickins <hughd@xxxxxxxxxx>
Subject: mm: fix the NULL mapping case in __isolate_lru_page()
George Boole would have noticed a slight error in 4.16 commit 69d763fc6d3a
("mm: pin address_space before dereferencing it while isolating an LRU
page"). Fix it, to match both the comment above it, and the original
behaviour.
Although anonymous pages are not marked PageDirty at first, we have an old
habit of calling SetPageDirty when a page is removed from swap cache: so
there's a category of ex-swap pages that are easily migratable, but were
inadvertently excluded from compaction's async migration in 4.16.
Link: http://lkml.kernel.org/r/alpine.LSU.2.11.1805302014001.12558@eggly.anvils
Fixes: 69d763fc6d3a ("mm: pin address_space before dereferencing it while isolating an LRU page")
Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>
Reported-by: Ivan Kalvachev <ikalvachev@xxxxxxxxx>
Cc: "Huang, Ying" <ying.huang@xxxxxxxxx>
Cc: Jan Kara <jack@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/vmscan.c~mm-fix-the-null-mapping-case-in-__isolate_lru_page mm/vmscan.c
--- a/mm/vmscan.c~mm-fix-the-null-mapping-case-in-__isolate_lru_page
+++ a/mm/vmscan.c
@@ -1418,7 +1418,7 @@ int __isolate_lru_page(struct page *page
return ret;
mapping = page_mapping(page);
- migrate_dirty = mapping && mapping->a_ops->migratepage;
+ migrate_dirty = !mapping || mapping->a_ops->migratepage;
unlock_page(page);
if (!migrate_dirty)
return ret;
_
Patches currently in -mm which might be from hughd@xxxxxxxxxx are
mm-huge_memoryc-__split_huge_page-use-atomic-clearpagedirty.patch
mm-fix-the-null-mapping-case-in-__isolate_lru_page.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
