The patch titled
Subject: proc: fix smaps and meminfo alignment
has been added to the -mm tree. Its filename is
proc-fix-smaps-and-meminfo-alignment.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/proc-fix-smaps-and-meminfo-alignment.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/proc-fix-smaps-and-meminfo-alignment.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Hugh Dickins <hughd@xxxxxxxxxx>
Subject: proc: fix smaps and meminfo alignment
The 4.17-rc /proc/meminfo and /proc/<pid>/smaps look ugly: single-digit
numbers (commonly 0) are misaligned. Remove seq_put_decimal_ull_width()'s
leftover optimization for single digits: it's wrong now that num_to_str()
takes care of the width.
Link: http://lkml.kernel.org/r/alpine.LSU.2.11.1805241554210.1326@eggly.anvils
Fixes: d1be35cb6f96 ("proc: add seq_put_decimal_ull_width to speed up /proc/pid/smaps")
Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
Cc: Andrei Vagin <avagin@xxxxxxxxxx>
Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/seq_file.c | 5 -----
1 file changed, 5 deletions(-)
diff -puN fs/seq_file.c~proc-fix-smaps-and-meminfo-alignment fs/seq_file.c
--- a/fs/seq_file.c~proc-fix-smaps-and-meminfo-alignment
+++ a/fs/seq_file.c
@@ -709,11 +709,6 @@ void seq_put_decimal_ull_width(struct se
if (m->count + width >= m->size)
goto overflow;
- if (num < 10) {
- m->buf[m->count++] = num + '0';
- return;
- }
-
len = num_to_str(m->buf + m->count, m->size - m->count, num, width);
if (!len)
goto overflow;
_
Patches currently in -mm which might be from hughd@xxxxxxxxxx are
proc-fix-smaps-and-meminfo-alignment.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
