The patch titled Subject: mm, memcg: propagate memory effective protection on setting memory.min/low has been added to the -mm tree. Its filename is mm-propagate-memory-effective-protection-on-setting-memorymin-low.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-propagate-memory-effective-protection-on-setting-memorymin-low.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-propagate-memory-effective-protection-on-setting-memorymin-low.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Roman Gushchin <guro@xxxxxx> Subject: mm, memcg: propagate memory effective protection on setting memory.min/low Explicitly propagate effective memory min/low values down by the tree. If there is the global memory pressure, it's not really necessary. Effective memory guarantees will be propagated automatically as we traverse memory cgroup tree in the reclaim path. But if there is no global memory pressure, effective memory protection still matters for local (memcg-scoped) memory pressure. So, we have to update effective limits in the subtree, if a user changes memory.min and memory.low values. Link: http://lkml.kernel.org/r/20180522132528.23769-1-guro@xxxxxx Signed-off-by: Roman Gushchin <guro@xxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxxxx> Cc: Vladimir Davydov <vdavydov.dev@xxxxxxxxx> Cc: Greg Thelen <gthelen@xxxxxxxxxx> Cc: Tejun Heo <tj@xxxxxxxxxx> Cc: Shuah Khan <shuah@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- mm/memcontrol.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff -puN mm/memcontrol.c~mm-propagate-memory-effective-protection-on-setting-memorymin-low mm/memcontrol.c --- a/mm/memcontrol.c~mm-propagate-memory-effective-protection-on-setting-memorymin-low +++ a/mm/memcontrol.c @@ -5374,7 +5374,7 @@ static int memory_min_show(struct seq_fi static ssize_t memory_min_write(struct kernfs_open_file *of, char *buf, size_t nbytes, loff_t off) { - struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); + struct mem_cgroup *iter, *memcg = mem_cgroup_from_css(of_css(of)); unsigned long min; int err; @@ -5385,6 +5385,11 @@ static ssize_t memory_min_write(struct k page_counter_set_min(&memcg->memory, min); + rcu_read_lock(); + for_each_mem_cgroup_tree(iter, memcg) + mem_cgroup_protected(NULL, iter); + rcu_read_unlock(); + return nbytes; } @@ -5404,7 +5409,7 @@ static int memory_low_show(struct seq_fi static ssize_t memory_low_write(struct kernfs_open_file *of, char *buf, size_t nbytes, loff_t off) { - struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); + struct mem_cgroup *iter, *memcg = mem_cgroup_from_css(of_css(of)); unsigned long low; int err; @@ -5415,6 +5420,11 @@ static ssize_t memory_low_write(struct k page_counter_set_low(&memcg->memory, low); + rcu_read_lock(); + for_each_mem_cgroup_tree(iter, memcg) + mem_cgroup_protected(NULL, iter); + rcu_read_unlock(); + return nbytes; } _ Patches currently in -mm which might be from guro@xxxxxx are mm-rename-page_counters-count-limit-into-usage-max.patch mm-memorylow-hierarchical-behavior.patch mm-treat-memorylow-value-inclusive.patch mm-docs-describe-memorylow-refinements.patch mm-introduce-memorymin.patch mm-introduce-memorymin-fix.patch mm-oom-refactor-the-oom_kill_process-function.patch mm-implement-mem_cgroup_scan_tasks-for-the-root-memory-cgroup.patch mm-oom-cgroup-aware-oom-killer.patch mm-oom-introduce-memoryoom_group.patch mm-oom-introduce-memoryoom_group-fix.patch mm-oom-add-cgroup-v2-mount-option-for-cgroup-aware-oom-killer.patch mm-oom-docs-describe-the-cgroup-aware-oom-killer.patch mm-oom-docs-describe-the-cgroup-aware-oom-killer-fix.patch cgroup-list-groupoom-in-cgroup-features.patch mm-fix-oom_kill-event-handling.patch mm-propagate-memory-effective-protection-on-setting-memorymin-low.patch mm-dont-skip-memory-guarantee-calculations.patch selftests-cgroup-add-test-for-memorylow-corner-cases.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html