The patch titled
Subject: hfsplus: stop workqueue when fill_super() failed
has been added to the -mm tree. Its filename is
hfsplus-stop-workqueue-when-fill_super-failed.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/hfsplus-stop-workqueue-when-fill_super-failed.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/hfsplus-stop-workqueue-when-fill_super-failed.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: hfsplus: stop workqueue when fill_super() failed
syzbot is reporting ODEBUG messages at hfsplus_fill_super() [1]. This is
because hfsplus_fill_super() forgot to call cancel_delayed_work_sync().
As far as I can see, it is hfsplus_mark_mdb_dirty() from
hfsplus_new_inode() in hfsplus_fill_super() that calls
queue_delayed_work(). Therefore, I assume that hfsplus_new_inode() does
not fail if queue_delayed_work() was called, and the out_put_hidden_dir
label is the appropriate location to call cancel_delayed_work_sync().
[1] https://syzkaller.appspot.com/bug?id=a66f45e96fdbeb76b796bf46eb25ea878c42a6c9
Link: http://lkml.kernel.org/r/964a8b27-cd69-357c-fe78-76b066056201@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Reported-by: syzbot <syzbot+4f2e5f086147d543ab03@xxxxxxxxxxxxxxxxxxxxxxxxx>
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Cc: David Howells <dhowells@xxxxxxxxxx>
Cc: Ernesto A. Fernandez <ernesto.mnd.fernandez@xxxxxxxxx>
Cc: Vyacheslav Dubeyko <slava@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/hfsplus/super.c | 1 +
1 file changed, 1 insertion(+)
diff -puN fs/hfsplus/super.c~hfsplus-stop-workqueue-when-fill_super-failed fs/hfsplus/super.c
--- a/fs/hfsplus/super.c~hfsplus-stop-workqueue-when-fill_super-failed
+++ a/fs/hfsplus/super.c
@@ -588,6 +588,7 @@ static int hfsplus_fill_super(struct sup
return 0;
out_put_hidden_dir:
+ cancel_delayed_work_sync(&sbi->sync_work);
iput(sbi->hidden_dir);
out_put_root:
dput(sb->s_root);
_
Patches currently in -mm which might be from penguin-kernel@xxxxxxxxxxxxxxxxxxx are
hfsplus-stop-workqueue-when-fill_super-failed.patch
dentry-fix-kmemcheck-splat-at-take_dentry_name_snapshot.patch
mm-check-for-sigkill-inside-dup_mmap-loop.patch
locking-hung_task-show-all-hung-tasks-before-panic.patch
bfs-add-sanity-check-at-bfs_fill_super.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
