The patch titled
Subject: checkpatch: whinge about bool bitfields
has been added to the -mm tree. Its filename is
checkpatch-whinge-about-bool-bitfields.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-whinge-about-bool-bitfields.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-whinge-about-bool-bitfields.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Joe Perches <joe@xxxxxxxxxxx>
Subject: checkpatch: whinge about bool bitfields
Using bool in a bitfield isn't a good idea as the alignment behavior is
arch implementation defined.
Suggest using unsigned int or u<8|16|32> instead.
Link: http://lkml.kernel.org/r/e22fb871b1b7f2fda4b22f3a24e0d7f092eb612c.camel@xxxxxxxxxxx
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff -puN scripts/checkpatch.pl~checkpatch-whinge-about-bool-bitfields scripts/checkpatch.pl
--- a/scripts/checkpatch.pl~checkpatch-whinge-about-bool-bitfields
+++ a/scripts/checkpatch.pl
@@ -6251,6 +6251,12 @@ sub process {
}
}
+# check for bool bitfields
+ if ($sline =~ /^.\s+bool\s*$Ident\s*:\s*\d+\s*;/) {
+ WARN("BOOL_BITFIELD",
+ "Avoid using bool as bitfield. Prefer bool bitfields as unsigned int or u<8|16|32>\n" . $herecurr);
+ }
+
# check for semaphores initialized locked
if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
WARN("CONSIDER_COMPLETION",
_
Patches currently in -mm which might be from joe@xxxxxxxxxxx are
checkpatch-improve-parse_email-signature-checking.patch
checkpatch-improve-get_quoted_string-for-trace_event-macros.patch
checkpatch-test-symbolic_perms-multiple-times-per-line.patch
checkpatch-add-test-for-assignment-at-start-of-line.patch
checkpatch-whinge-about-bool-bitfields.patch
checkpatch-add-a-strict-test-for-structs-with-bool-member-definitions.patch
maintainers-update-bouncing-aacraid-adapteccom-addresses.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
