- remove-silly-messages-from-input-layer.patch removed from -mm tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch titled

     Remove silly messages from input layer

has been removed from the -mm tree.  Its filename is

     remove-silly-messages-from-input-layer.patch

This patch was dropped because it is obsolete

------------------------------------------------------
Subject: Remove silly messages from input layer
From: Dave Jones <davej@xxxxxxxxxx>

There are two messages in the input layer that seem to be triggerable very
easily, and they confuse end-users to no end.  "too many keys pressed? 
Should I press less keys?" I actually got a complaint from one user that he
had only hit one key before being told to type less.

The latter message seems to trigger with certain keyboard switchers and
again, does nothing but confuse people.

Best of all, asides from the silly messages, none of the people suffering
them report any other misbehaviour, their keyboards work just fine.

Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
Cc: Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
---

 drivers/input/keyboard/atkbd.c |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)

diff -puN drivers/input/keyboard/atkbd.c~remove-silly-messages-from-input-layer drivers/input/keyboard/atkbd.c
--- a/drivers/input/keyboard/atkbd.c~remove-silly-messages-from-input-layer
+++ a/drivers/input/keyboard/atkbd.c
@@ -396,7 +396,6 @@ static irqreturn_t atkbd_interrupt(struc
 			add_release_event = 1;
 			break;
 		case ATKBD_RET_ERR:
-			printk(KERN_DEBUG "atkbd.c: Keyboard on %s reports too many keys pressed.\n", serio->phys);
 			goto out;
 	}
 
@@ -414,14 +413,16 @@ static irqreturn_t atkbd_interrupt(struc
 		case ATKBD_KEY_NULL:
 			break;
 		case ATKBD_KEY_UNKNOWN:
-			printk(KERN_WARNING
-			       "atkbd.c: Unknown key %s (%s set %d, code %#x on %s).\n",
-			       atkbd->release ? "released" : "pressed",
-			       atkbd->translated ? "translated" : "raw",
-			       atkbd->set, code, serio->phys);
-			printk(KERN_WARNING
-			       "atkbd.c: Use 'setkeycodes %s%02x <keycode>' to make it known.\n",
-			       code & 0x80 ? "e0" : "", code & 0x7f);
+			if (data != ATKBD_RET_ACK && data != ATKBD_RET_NAK) {
+				printk(KERN_WARNING "atkbd.c: Unknown key %s "
+					"(%s set %d, code %#x on %s).\n",
+					atkbd->release ? "released" : "pressed",
+					atkbd->translated ? "translated":"raw",
+					atkbd->set, code, serio->phys);
+				printk(KERN_WARNING "atkbd.c: Use 'setkeycodes "
+					"%s%02x <keycode>' to make it known.\n",
+					code & 0x80 ? "e0" : "", code & 0x7f);
+			}
 			input_sync(dev);
 			break;
 		case ATKBD_SCR_1:
_

Patches currently in -mm which might be from davej@xxxxxxxxxx are

origin.patch
remove-silly-messages-from-input-layer.patch
git-netdev-all.patch
remove-pointless-printk-from-i386-oops-output.patch
compress-stack-unwinder-output.patch
move-rmap-bug_on-outside-debug_vm.patch

-
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Kernel Newbies FAQ]     [Kernel Archive]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Photo]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux