The patch titled
Subject: fscache: use appropriate radix tree accessors
has been added to the -mm tree. Its filename is
fscache-use-appropriate-radix-tree-accessors.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/fscache-use-appropriate-radix-tree-accessors.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/fscache-use-appropriate-radix-tree-accessors.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
Subject: fscache: use appropriate radix tree accessors
Don't open-code accesses to data structure internals.
Link: http://lkml.kernel.org/r/20180313132639.17387-7-willy@xxxxxxxxxxxxx
Signed-off-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
Cc: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
Cc: Dave Chinner <david@xxxxxxxxxxxxx>
Cc: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxxxxxx>
Cc: Will Deacon <will.deacon@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/fscache/cookie.c | 2 +-
fs/fscache/object.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff -puN fs/fscache/cookie.c~fscache-use-appropriate-radix-tree-accessors fs/fscache/cookie.c
--- a/fs/fscache/cookie.c~fscache-use-appropriate-radix-tree-accessors
+++ a/fs/fscache/cookie.c
@@ -608,7 +608,7 @@ void __fscache_relinquish_cookie(struct
/* Clear pointers back to the netfs */
cookie->netfs_data = NULL;
cookie->def = NULL;
- BUG_ON(cookie->stores.rnode);
+ BUG_ON(!radix_tree_empty(&cookie->stores));
if (cookie->parent) {
ASSERTCMP(atomic_read(&cookie->parent->usage), >, 0);
diff -puN fs/fscache/object.c~fscache-use-appropriate-radix-tree-accessors fs/fscache/object.c
--- a/fs/fscache/object.c~fscache-use-appropriate-radix-tree-accessors
+++ a/fs/fscache/object.c
@@ -956,7 +956,7 @@ static const struct fscache_state *_fsca
* retire the object instead.
*/
if (!fscache_use_cookie(object)) {
- ASSERT(object->cookie->stores.rnode == NULL);
+ ASSERT(radix_tree_empty(&object->cookie->stores));
set_bit(FSCACHE_OBJECT_RETIRED, &object->flags);
_leave(" [no cookie]");
return transit_to(KILL_OBJECT);
_
Patches currently in -mm which might be from mawilcox@xxxxxxxxxxxxx are
radix-tree-use-gfp_zonemask-bits-of-gfp_t-for-flags.patch
arm64-turn-flush_dcache_mmap_lock-into-a-no-op.patch
unicore32-turn-flush_dcache_mmap_lock-into-a-no-op.patch
export-__set_page_dirty.patch
fscache-use-appropriate-radix-tree-accessors.patch
xarray-add-the-xa_lock-to-the-radix_tree_root.patch
page-cache-use-xa_lock.patch
autofs4-use-wait_event_killable.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
