The patch titled
Subject: mm,oom_reaper: check for MMF_OOM_SKIP before complaining
has been added to the -mm tree. Its filename is
mmoom_reaper-check-for-mmf_oom_skip-before-complain.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mmoom_reaper-check-for-mmf_oom_skip-before-complain.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mmoom_reaper-check-for-mmf_oom_skip-before-complain.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Subject: mm,oom_reaper: check for MMF_OOM_SKIP before complaining
I got "oom_reaper: unable to reap pid:" messages when the victim thread
was blocked inside free_pgtables() (which occurred after returning from
unmap_vmas() and setting MMF_OOM_SKIP). We don't need to complain when
exit_mmap() already set MMF_OOM_SKIP.
[ 663.593821] Killed process 7558 (a.out) total-vm:4176kB, anon-rss:84kB, file-rss:0kB, shmem-rss:0kB
[ 664.684801] oom_reaper: unable to reap pid:7558 (a.out)
[ 664.892292] a.out D13272 7558 6931 0x00100084
[ 664.895765] Call Trace:
[ 664.897574] ? __schedule+0x25f/0x780
[ 664.900099] schedule+0x2d/0x80
[ 664.902260] rwsem_down_write_failed+0x2bb/0x440
[ 664.905249] ? rwsem_down_write_failed+0x55/0x440
[ 664.908335] ? free_pgd_range+0x569/0x5e0
[ 664.911145] call_rwsem_down_write_failed+0x13/0x20
[ 664.914121] down_write+0x49/0x60
[ 664.916519] ? unlink_file_vma+0x28/0x50
[ 664.919255] unlink_file_vma+0x28/0x50
[ 664.922234] free_pgtables+0x36/0x100
[ 664.924797] exit_mmap+0xbb/0x180
[ 664.927220] mmput+0x50/0x110
[ 664.929504] copy_process.part.41+0xb61/0x1fe0
[ 664.932448] ? _do_fork+0xe6/0x560
[ 664.934902] ? _do_fork+0xe6/0x560
[ 664.937361] _do_fork+0xe6/0x560
[ 664.939742] ? syscall_trace_enter+0x1a9/0x240
[ 664.942693] ? retint_user+0x18/0x18
[ 664.945309] ? page_fault+0x2f/0x50
[ 664.947896] ? trace_hardirqs_on_caller+0x11f/0x1b0
[ 664.951075] do_syscall_64+0x74/0x230
[ 664.953747] entry_SYSCALL_64_after_hwframe+0x42/0xb7
Link: http://lkml.kernel.org/r/201803221946.DHG65638.VFJHFtOSQLOMOF@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
Acked-by: Michal Hocko <mhocko@xxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/oom_kill.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN mm/oom_kill.c~mmoom_reaper-check-for-mmf_oom_skip-before-complain mm/oom_kill.c
--- a/mm/oom_kill.c~mmoom_reaper-check-for-mmf_oom_skip-before-complain
+++ a/mm/oom_kill.c
@@ -590,7 +590,8 @@ static void oom_reap_task(struct task_st
while (attempts++ < MAX_OOM_REAP_RETRIES && !__oom_reap_task_mm(tsk, mm))
schedule_timeout_idle(HZ/10);
- if (attempts <= MAX_OOM_REAP_RETRIES)
+ if (attempts <= MAX_OOM_REAP_RETRIES ||
+ test_bit(MMF_OOM_SKIP, &mm->flags))
goto done;
_
Patches currently in -mm which might be from penguin-kernel@xxxxxxxxxxxxxxxxxxx are
lockdep-fix-fs_reclaim-warning.patch
dentry-fix-kmemcheck-splat-at-take_dentry_name_snapshot.patch
mmvmscan-dont-pretend-forward-progress-upon-shrinker_rwsem-contention.patch
mmoom_reaper-check-for-mmf_oom_skip-before-complain.patch
mmvmscan-mark-register_shrinker-as-__must_check.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
