The patch titled Subject: mm/vmscan: update stale comments has been added to the -mm tree. Its filename is mm-vmscan-update-stale-comments.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/mm-vmscan-update-stale-comments.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/mm-vmscan-update-stale-comments.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> Subject: mm/vmscan: update stale comments Update some comments that became stale since transiton from per-zone to per-node reclaim. Link: http://lkml.kernel.org/r/20180315164553.17856-2-aryabinin@xxxxxxxxxxxxx Signed-off-by: Andrey Ryabinin <aryabinin@xxxxxxxxxxxxx> Cc: Shakeel Butt <shakeelb@xxxxxxxxxx> Cc: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx> Cc: Tejun Heo <tj@xxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- diff -puN mm/vmscan.c~mm-vmscan-update-stale-comments mm/vmscan.c --- a/mm/vmscan.c~mm-vmscan-update-stale-comments +++ a/mm/vmscan.c @@ -926,7 +926,7 @@ static unsigned long shrink_page_list(st (PageSwapCache(page) && (sc->gfp_mask & __GFP_IO)); /* - * The number of dirty pages determines if a zone is marked + * The number of dirty pages determines if a node is marked * reclaim_congested which affects wait_iff_congested. kswapd * will stall and start writing pages if the tail of the LRU * is all dirty unqueued pages. @@ -1764,7 +1764,7 @@ shrink_inactive_list(unsigned long nr_to * as there is no guarantee the dirtying process is throttled in the * same way balance_dirty_pages() manages. * - * Once a zone is flagged ZONE_WRITEBACK, kswapd will count the number + * Once a node is flagged PGDAT_WRITEBACK, kswapd will count the number * of pages under pages flagged for immediate reclaim and stall if any * are encountered in the nr_immediate check below. */ @@ -1791,7 +1791,7 @@ shrink_inactive_list(unsigned long nr_to */ if (sane_reclaim(sc)) { /* - * Tag a zone as congested if all the dirty pages scanned were + * Tag a node as congested if all the dirty pages scanned were * backed by a congested BDI and wait_iff_congested will stall. */ if (stat.nr_dirty && stat.nr_dirty == stat.nr_congested) @@ -1812,7 +1812,7 @@ shrink_inactive_list(unsigned long nr_to } /* - * Stall direct reclaim for IO completions if underlying BDIs or zone + * Stall direct reclaim for IO completions if underlying BDIs and node * is congested. Allow kswapd to continue until it starts encountering * unqueued dirty pages or cycling through the LRU too quickly. */ @@ -3808,7 +3808,7 @@ static int __node_reclaim(struct pglist_ if (node_pagecache_reclaimable(pgdat) > pgdat->min_unmapped_pages) { /* - * Free memory by calling shrink zone with increasing + * Free memory by calling shrink node with increasing * priorities until we have enough memory freed. */ do { _ Patches currently in -mm which might be from aryabinin@xxxxxxxxxxxxx are mm-vmscan-wake-up-flushers-for-legacy-cgroups-too.patch mm-vmscan-update-stale-comments.patch mm-vmscan-replace-mm_vmscan_lru_shrink_inactive-with-shrink_page_list-tracepoint.patch mm-vmscan-remove-redundant-current_may_throttle-check.patch mm-vmscan-dont-change-pgdat-state-on-base-of-a-single-lru-list-state.patch mm-vmscan-dont-mess-with-pgdat-flags-in-memcg-reclaim.patch mm-kasan-dont-vfree-nonexistent-vm_area.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html