The patch titled
Subject: mm/swap_state.c: make bool enable_vma_readahead and swap_vma_readahead() static
has been added to the -mm tree. Its filename is
mm-swap-make-bool-enable_vma_readahead-and-function-swap_vma_readahead-static.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/mm-swap-make-bool-enable_vma_readahead-and-function-swap_vma_readahead-static.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/mm-swap-make-bool-enable_vma_readahead-and-function-swap_vma_readahead-static.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Subject: mm/swap_state.c: make bool enable_vma_readahead and swap_vma_readahead() static
The bool enable_vma_readahead and swap_vma_readahead() are local to the
source and do not need to be in global scope, so make them static.
Cleans up sparse warnings:
mm/swap_state.c:41:6: warning: symbol 'enable_vma_readahead' was not
declared. Should it be static?
mm/swap_state.c:742:13: warning: symbol 'swap_vma_readahead' was not
declared. Should it be static?
Link: http://lkml.kernel.org/r/20180223164852.5159-1-colin.king@xxxxxxxxxxxxx
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Acked-by: "Huang, Ying" <ying.huang@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/swap_state.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN mm/swap_state.c~mm-swap-make-bool-enable_vma_readahead-and-function-swap_vma_readahead-static mm/swap_state.c
--- a/mm/swap_state.c~mm-swap-make-bool-enable_vma_readahead-and-function-swap_vma_readahead-static
+++ a/mm/swap_state.c
@@ -38,7 +38,7 @@ static const struct address_space_operat
struct address_space *swapper_spaces[MAX_SWAPFILES] __read_mostly;
static unsigned int nr_swapper_spaces[MAX_SWAPFILES] __read_mostly;
-bool enable_vma_readahead __read_mostly = true;
+static bool enable_vma_readahead __read_mostly = true;
#define SWAP_RA_WIN_SHIFT (PAGE_SHIFT / 2)
#define SWAP_RA_HITS_MASK ((1UL << SWAP_RA_WIN_SHIFT) - 1)
@@ -733,8 +733,8 @@ static void swap_ra_info(struct vm_fault
pte_unmap(orig_pte);
}
-struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask,
- struct vm_fault *vmf)
+static struct page *swap_vma_readahead(swp_entry_t fentry, gfp_t gfp_mask,
+ struct vm_fault *vmf)
{
struct blk_plug plug;
struct vm_area_struct *vma = vmf->vma;
_
Patches currently in -mm which might be from colin.king@xxxxxxxxxxxxx are
mm-ksm-make-function-stable_node_dup-static.patch
mm-swap-make-bool-enable_vma_readahead-and-function-swap_vma_readahead-static.patch
mm-swap-make-pointer-swap_avail_heads-static.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
