The patch titled
Subject: slub: remove obsolete comments of put_cpu_partial()
has been added to the -mm tree. Its filename is
slub-remove-obsolete-comments-of-put_cpu_partial.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/slub-remove-obsolete-comments-of-put_cpu_partial.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/slub-remove-obsolete-comments-of-put_cpu_partial.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Miles Chen <miles.chen@xxxxxxxxxxxx>
Subject: slub: remove obsolete comments of put_cpu_partial()
d6e0b7fa1186 ("slub: make dead caches discard free slabs immediately")
makes put_cpu_partial() run with preemption disabled and interrupts
disabled when calling unfreeze_partials().
The comment: "put_cpu_partial() is done without interrupts disabled and
without preemption disabled" looks obsolete, so remove it.
Link: http://lkml.kernel.org/r/1516968550-1520-1-git-send-email-miles.chen@xxxxxxxxxxxx
Signed-off-by: Miles Chen <miles.chen@xxxxxxxxxxxx>
Reviewed-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Christoph Lameter <cl@xxxxxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Cc: David Rientjes <rientjes@xxxxxxxxxx>
Cc: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx>
Cc: Vladimir Davydov <vdavydov.dev@xxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
mm/slub.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff -puN mm/slub.c~slub-remove-obsolete-comments-of-put_cpu_partial mm/slub.c
--- a/mm/slub.c~slub-remove-obsolete-comments-of-put_cpu_partial
+++ a/mm/slub.c
@@ -2222,9 +2222,7 @@ static void unfreeze_partials(struct kme
/*
* Put a page that was just frozen (in __slab_free) into a partial page
- * slot if available. This is done without interrupts disabled and without
- * preemption disabled. The cmpxchg is racy and may put the partial page
- * onto a random cpus partial slot.
+ * slot if available.
*
* If we did not find a slot then simply move all the partials to the
* per node partial list.
_
Patches currently in -mm which might be from miles.chen@xxxxxxxxxxxx are
slub-remove-obsolete-comments-of-put_cpu_partial.patch
--
To unsubscribe from this list: send the line "unsubscribe mm-commits" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
