The patch titled Subject: checkpatch: avoid some false positives for TABSTOP declaration test has been added to the -mm tree. Its filename is checkpatch-avoid-some-false-positives-for-tabstop-declaration-test.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/checkpatch-avoid-some-false-positives-for-tabstop-declaration-test.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/checkpatch-avoid-some-false-positives-for-tabstop-declaration-test.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Joe Perches <joe@xxxxxxxxxxx> Subject: checkpatch: avoid some false positives for TABSTOP declaration test Using an open bracket after what seems to be a declaration can also be a function definition and declaration argument line continuation so remove the open bracket from the possible declaration/definition matching. e.g.: int foobar(int a; int *b[]); Link: http://lkml.kernel.org/r/1515704479.9619.171.camel@xxxxxxxxxxx Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> Reported-by: Sven Eckelmann <sven@xxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN scripts/checkpatch.pl~checkpatch-avoid-some-false-positives-for-tabstop-declaration-test scripts/checkpatch.pl --- a/scripts/checkpatch.pl~checkpatch-avoid-some-false-positives-for-tabstop-declaration-test +++ a/scripts/checkpatch.pl @@ -3020,7 +3020,7 @@ sub process { # check indentation starts on a tab stop if ($^V && $^V ge 5.10.0 && - $sline =~ /^\+\t+( +)(?:$c90_Keywords\b|\{\s*$|\}\s*(?:else\b|while\b|\s*$)|$Declare\s*$Ident\s*[;=\[])/) { + $sline =~ /^\+\t+( +)(?:$c90_Keywords\b|\{\s*$|\}\s*(?:else\b|while\b|\s*$)|$Declare\s*$Ident\s*[;=])/) { my $indent = length($1); if ($indent % 8) { if (WARN("TABSTOP", _ Patches currently in -mm which might be from joe@xxxxxxxxxxx are checkpatch-ignore-some-octal-permissions-of-0.patch checkpatch-improve-quoted-string-and-line-continuation-test.patch checkpatch-add-a-few-device_attr-style-tests.patch checkpatch-improve-the-tabstop-test-to-include-declarations.patch checkpatch-exclude-drivers-staging-from-if-with-unnecessary-parentheses-test.patch checkpatch-avoid-some-false-positives-for-tabstop-declaration-test.patch -- To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html