The patch titled Char: mxser_new, testbit for bit testing has been added to the -mm tree. Its filename is char-mxser_new-testbit-for-bit-testing.patch See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this ------------------------------------------------------ Subject: Char: mxser_new, testbit for bit testing From: Jiri Slaby <jirislaby@xxxxxxxxx> Use testbit like in tty subsystem for TTY_IO_ERROR testing. Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxx> --- drivers/char/mxser_new.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff -puN drivers/char/mxser_new.c~char-mxser_new-testbit-for-bit-testing drivers/char/mxser_new.c --- a/drivers/char/mxser_new.c~char-mxser_new-testbit-for-bit-testing +++ a/drivers/char/mxser_new.c @@ -461,7 +461,8 @@ static int mxser_block_til_ready(struct * If non-blocking mode is set, or the port is not enabled, * then make the check up front and then exit. */ - if ((filp->f_flags & O_NONBLOCK) || (tty->flags & (1 << TTY_IO_ERROR))) { + if ((filp->f_flags & O_NONBLOCK) || + test_bit(TTY_IO_ERROR, &tty->flags)) { port->flags |= ASYNC_NORMAL_ACTIVE; return 0; } @@ -1437,7 +1438,7 @@ static int mxser_tiocmget(struct tty_str if (tty->index == MXSER_PORTS) return -ENOIOCTLCMD; - if (tty->flags & (1 << TTY_IO_ERROR)) + if (test_bit(TTY_IO_ERROR, &tty->flags)) return -EIO; control = info->MCR; @@ -1464,7 +1465,7 @@ static int mxser_tiocmset(struct tty_str if (tty->index == MXSER_PORTS) return -ENOIOCTLCMD; - if (tty->flags & (1 << TTY_IO_ERROR)) + if (test_bit(TTY_IO_ERROR, &tty->flags)) return -EIO; spin_lock_irqsave(&info->slock, flags); @@ -1798,10 +1799,10 @@ static int mxser_ioctl(struct tty_struct } /* above add by Victor Yu. 01-05-2004 */ - if ((cmd != TIOCGSERIAL) && (cmd != TIOCMIWAIT) && (cmd != TIOCGICOUNT)) { - if (tty->flags & (1 << TTY_IO_ERROR)) - return -EIO; - } + if (cmd != TIOCGSERIAL && cmd != TIOCMIWAIT && cmd != TIOCGICOUNT && + test_bit(TTY_IO_ERROR, &tty->flags)) + return -EIO; + switch (cmd) { case TCSBRK: /* SVID version: non-zero arg --> no break */ retval = tty_check_change(tty); _ Patches currently in -mm which might be from jirislaby@xxxxxxxxx are pci-mxser-pci-refcounts.patch mxser-make-an-experimental-clone.patch char-mxser_new-correct-include-file.patch char-mxser_new-upgrade-to-191.patch char-mxser_new-rework-to-allow-dynamic-structs.patch char-mxser_new-use-__devinit-macros.patch char-mxser_new-pci_request_region-for-pci-regions.patch char-mxser_new-check-request_region-retvals.patch char-mxser_new-kill-unneeded-memsets.patch char-mxser_new-revert-spin_lock-changes.patch char-mxser_new-remove-request-for-testers-line.patch char-mxser_new-debug-printk-dependent-on-debug.patch char-mxser_new-alter-license-terms.patch char-mxser_new-code-upside-down.patch char-mxser_new-cmspar-is-defined.patch char-remove-unneded-termbits-redefinitions-mxser_new.patch char-mxser_new-eliminate-tty-ldisc-deref.patch char-mxser_new-testbit-for-bit-testing.patch char-mxser_new-correct-fail-paths.patch char-mxser_new-dont-check-tty_unregister-retval.patch char-mxser_new-compress-isa-finding.patch char-mxser_new-register-tty-devices-on-the-fly.patch - To unsubscribe from this list: send the line "unsubscribe mm-commits" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html